Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4ae3b23da26b52582ba246d300fc25acdc0e6816
https://github.com/WebKit/WebKit/commit/4ae3b23da26b52582ba246d300fc25acdc0e6816
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
A LayoutTests/media/video-webm-seek-multi-audio-tracks-expected.txt
A LayoutTests/media/video-webm-seek-multi-audio-tracks.html
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
Log Message:
-----------
Crash in WebCore::MediaPlayerPrivateWebM::reenqueueMediaForTime
https://bugs.webkit.org/show_bug.cgi?id=316880
rdar://179182491
Reviewed by Eric Carlson.
Should a track become disabled while seeking, the renderer's track would
get destroyed and removed from the m_trackIdentifiers. The code assumed
that if the trackIdentifier was in m_trackBufferMap , then it would be enabled.
We now guard against this by first checking if the trackIdentifier is in the
map and abort.
Added tests.
* LayoutTests/media/video-webm-seek-multi-audio-tracks-expected.txt: Added.
* LayoutTests/media/video-webm-seek-multi-audio-tracks.html: Added.
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::reenqueueMediaForTime):
(WebCore::MediaPlayerPrivateWebM::trackDidChangeEnabled): Pre-emptive
correctness. Just in case as it's a similar pattern as the above.
Canonical link: https://commits.webkit.org/314993@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications