Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8aab904f7092297ec74b591486cc700379fe61d5
https://github.com/WebKit/WebKit/commit/8aab904f7092297ec74b591486cc700379fe61d5
Author: Kristian Monsen <[email protected]>
Date: 2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
A LayoutTests/ipc/webrtc-create-socket-empty-address-crash-expected.txt
A LayoutTests/ipc/webrtc-create-socket-empty-address-crash.html
A LayoutTests/ipc/webrtc-send-to-socket-empty-address-crash-expected.txt
A LayoutTests/ipc/webrtc-send-to-socket-empty-address-crash.html
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
Log Message:
-----------
Reject WebRTC socket creation with empty address to fix crash
https://bugs.webkit.org/show_bug.cgi?id=315726
rdar://177615751
Reviewed by Youenn Fablet.
NetworkRTCProvider::createUDPSocket and createClientTCPSocket on Cocoa would
crash when passed a socket address with a nil IP and empty hostname.
The crash occurred in nw_endpoint_create_host_with_numeric_port when called
with an empty string.
The fix adds an early check rejecting such addresses and calling
signalSocketIsClosed to notify the caller gracefully instead of crashing.
Test: ipc/webrtc-create-socket-empty-address-crash.html
* LayoutTests/ipc/webrtc-create-socket-empty-address-crash-expected.txt: Added.
* LayoutTests/ipc/webrtc-create-socket-empty-address-crash.html: Added.
* LayoutTests/ipc/webrtc-send-to-socket-empty-address-crash-expected.txt: Added.
* LayoutTests/ipc/webrtc-send-to-socket-empty-address-crash.html: Added.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::isEmptyRTCAddress):
(WebKit::NetworkRTCProvider::sendToSocket):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
Canonical link: https://commits.webkit.org/314720@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
