Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5a4cbb2ccc9489472d16cc279874532abdf4491
https://github.com/WebKit/WebKit/commit/b5a4cbb2ccc9489472d16cc279874532abdf4491
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-05-27 (Wed, 27 May 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitperl/FeatureList.pm
Log Message:
-----------
[WPE][GTK] Warn in build-webkit when building Release without assertions
https://bugs.webkit.org/show_bug.cgi?id=315565
Reviewed by Justin Michaud.
The GTK and WPE EWS bots build and test with -DENABLE_ASSERTS=ON for
both Release and Debug, but the default developer build does not match
this configuration on Release (where the CMake default value disables
assertions). This mismatch means that issues caught by assertions on
the CI can go unnoticed when reproducing locally.
Rather than silently changing the default for everyone, surface the
mismatch more clearly so developers can opt in:
* Expose ENABLE_ASSERTS as a build-webkit feature option, so
--asserts / --no-asserts can be passed to enable or disable
assertions explicitly (translating into -DENABLE_ASSERTS=ON|OFF
for CMake-based builds).
* Print a one-line warning at CMake configure time when building
GTK or WPE without assertions enabled. On Release this warns
unless --asserts (or an equivalent -DENABLE_ASSERTS=ON) is
passed; on Debug it warns only when assertions have been
explicitly disabled via --no-asserts or -DENABLE_ASSERTS=OFF.
* Tools/Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
* Tools/Scripts/webkitperl/FeatureList.pm:
Canonical link: https://commits.webkit.org/313986@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
