Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db8991a09bbaa76245bd456a4a1e961f956291eb
https://github.com/WebKit/WebKit/commit/db8991a09bbaa76245bd456a4a1e961f956291eb
Author: Zak Ridouh <[email protected]>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M Source/WebKit/Headers.cmake
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/Shared/API/c/WKBase.h
M Source/WebKit/Sources.txt
M Source/WebKit/UIProcess/API/C/WKAPICast.h
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPageUIClient.h
R Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.cpp
R Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKit/WKPage/UserMedia.cpp
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
Log Message:
-----------
Remove dead WKUserMediaPermissionCheck C API
https://bugs.webkit.org/show_bug.cgi?id=314499
rdar://176713900
Reviewed by Alex Christensen.
The WKPageUIClient `checkUserMediaPermissionForOrigin` slot was retired
to `void* unused6` previously, which already cut off the only path by
which an external caller could receive a WKUserMediaPermissionCheckRef.
The C API wrapper (WKUserMediaPermissionCheckGetTypeID,
WKUserMediaPermissionCheckSetUserMediaAccessInfo) has no remaining
callers. Delete it, along with the opaque WKUserMediaPermissionCheckRef
typedef, the WK_ADD_API_MAPPING, the orphan WKCheckUserMediaPermissionCallback
typedef, stale includes in WKPage.cpp and the test tools, and the
build-system plumbing (Sources.txt, Headers.cmake, modulemaps,
WebKit.xcodeproj).
The backing UserMediaPermissionCheckProxy class is kept as-is: the
glib build still references it even though its construction path is
also unreachable. Dropping it is a larger GTK/WPE public-API change
and out of scope here.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKPage/UserMedia.cpp
* Source/WebKit/Headers.cmake:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Shared/API/c/WKBase.h:
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/API/C/WKAPICast.h:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
* Source/WebKit/UIProcess/API/C/WKPageUIClient.h:
* Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.cpp: Removed.
* Source/WebKit/UIProcess/API/C/WKUserMediaPermissionCheck.h: Removed.
* Source/WebKit/UIProcess/Inspector/WasmDebuggerDebuggable.cpp:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/UserMedia.cpp:
* Tools/WebKitTestRunner/TestController.cpp:
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
Canonical link: https://commits.webkit.org/313756@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
