Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1c4443e0c62b6ce58a3d277908ecbafaf988a7dd
https://github.com/WebKit/WebKit/commit/1c4443e0c62b6ce58a3d277908ecbafaf988a7dd
Author: Zak Ridouh <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Source/WebCore/PlatformMac.cmake
Log Message:
-----------
[CMake] Stage WebCore.framework bundle resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=315325
rdar://177664337
Reviewed by Alan Baradlay and Pascoe.
The CMake Mac port was not copying Source/WebCore/Resources/*.{png,tiff,
icc,html,...} into WebCore.framework/Versions/A/Resources/, so the
framework bundle shipped with only Info.plist and en.lproj/. As a
result, ImageAdapter::loadPlatformResource() — which uses
[NSBundle bundleForClass:WebCoreBundleFinder] to look up missingImage.png
and similar built-in images — returned nil, and any failed image load
crashed the WebContent process via ASSERT_NOT_REACHED() in
CachedImage::brokenImage(). The Xcode build copies these via its
Resources build phase; CMake had no equivalent.
Glob Source/WebCore/Resources/* and stage with WEBKIT_COPY_FILES so
new resources are picked up automatically. CONFIGURE_DEPENDS triggers a
re-glob when the directory changes.
* Source/WebCore/PlatformMac.cmake:
Canonical link: https://commits.webkit.org/313697@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
