Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 077d9a85001864326e0505a46b49c182dd4a89ac
https://github.com/WebKit/WebKit/commit/077d9a85001864326e0505a46b49c182dd4a89ac
Author: Zak Ridouh <[email protected]>
Date: 2026-05-01 (Fri, 01 May 2026)
Changed paths:
M Source/WebCore/PlatformMac.cmake
Log Message:
-----------
[CMake] Fix macOS build after 312428@main by adding rendering/cocoa to
WebCore include dirs
https://bugs.webkit.org/show_bug.cgi?id=313839
rdar://176042265
Reviewed by Geoffrey Garen.
Commit 312428@main ([WebCore] Fix underlying build errors hidden by
UnifiedBuild files) added a direct `#include "RenderThemeCocoa.h"` in
Source/WebCore/page/InteractionRegion.cpp, which is gated on
ENABLE(FORM_CONTROL_REFRESH). RenderThemeCocoa.h lives in
Source/WebCore/rendering/cocoa, but that directory was never part of
WebCore_PRIVATE_INCLUDE_DIRECTORIES, so the Mac CMake port fails with:
Source/WebCore/page/InteractionRegion.cpp:79:10: fatal error:
'RenderThemeCocoa.h' file not found
The Xcode build happened to find the header via its own header search
paths, so the problem only shows up in the CMake Mac port.
Add rendering/cocoa to WebCore_PRIVATE_INCLUDE_DIRECTORIES in
PlatformMac.cmake so the header resolves the same way the sibling
rendering/mac directory's headers already do (via -I from other paths).
* Source/WebCore/PlatformMac.cmake: Add ${WEBCORE_DIR}/rendering/cocoa
to WebCore_PRIVATE_INCLUDE_DIRECTORIES.
Canonical link: https://commits.webkit.org/312448@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
