Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5ebc12da8948321a58cf8aef37923e61692c072
https://github.com/WebKit/WebKit/commit/b5ebc12da8948321a58cf8aef37923e61692c072
Author: Razvan Caliman <[email protected]>
Date: 2026-05-01 (Fri, 01 May 2026)
Changed paths:
M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
M Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css
M Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
Log Message:
-----------
Web Inspector: Record first input far too small within Graphics tab
https://bugs.webkit.org/show_bug.cgi?id=297082
rdar://157787230
Reviewed by Qianlang Chen.
The custom autosizing of the input field based on its content is replaced
with the standard CSS `field-sizing: content` property.
Also, increase the `min-width` to account for the number input
increment/decrement
buttons in contemporary macOS. This is only applicable when the placeholder is
set.
When a value is set, the `field-sizing: content` appropriately sizes the
element.
The UX of the number input field was also broken making it impossible to type
more
than one character at a time because on every keypress the DOM structure for
the label,
which included the input field itself, would get rebuilt to represent the
plural form
for the number of frames in the label text. This caused input focus to be lost
on every keypress.
Previously, this was worked around using programmatic selection. That does not
work anymore after
https://commits.webkit.org/247274@main which made WebKit spec compliant and
removed
support for `selectionStart` / `selectionEnd` from number input fields.
This patch changes the string used for the label so that it is no longer
necessary
to account for pluralization and no need to update the DOM structure at runtime.
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css:
(.navigation-bar > .item.canvas-recording-auto-capture > label > input):
* Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput):
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
Deleted.
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
Deleted.
Canonical link: https://commits.webkit.org/312433@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
