Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 91728e0e57bb8b1344d63e29f5f2c981d0d0dd0e
https://github.com/WebKit/WebKit/commit/91728e0e57bb8b1344d63e29f5f2c981d0d0dd0e
Author: Suraj Thanugundla <[email protected]>
Date: 2026-04-30 (Thu, 30 Apr 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-implicit-001.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-implicit-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-002.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-basics-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-basics.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-named-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-named.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-003.html
M
LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative.html
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/AnchorPositionEvaluator.cpp
A Source/WebCore/style/values/anchor-position/StylePositionAnchor.cpp
M Source/WebCore/style/values/anchor-position/StylePositionAnchor.h
M Source/WebCore/style/values/filter-effects/StyleAppleColorFilter.h
Log Message:
-----------
Accept none and normal values for position-anchor CSS property
https://bugs.webkit.org/show_bug.cgi?id=308981
Reviewed by Antti Koivisto.
https://drafts.csswg.org/css-anchor-position-1/#position-anchor
Add support for parsing, style computation and layout of none and normal
values for position-anchor CSS property. The new default value is normal.
position-anchor: normal and position-area: none is equivalent to
position-anchor: none.
Update tests that expected position-anchor:auto by default.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-implicit-001.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-implicit-002.html:
*
LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/the-anchor-attribute-003.tentative.html:
Update parsing and computed style tests
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-basics-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-basics.html:
Add new layout tests
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-001-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-001.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-002-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-auto-pseudo-element-implicit-002.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-001-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-001.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-002-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-implicit-002.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-named-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-none-pseudo-element-named.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-001-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-001.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-002-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-002.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-003-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-normal-pseudo-element-implicit-003.html:
Added.
Layout Changes
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::findAnchorsForAnchorPositionedElement):
If the element has none as it's default anchor then do not add the implicit
anchor
to the anchorToAnchorPositionedMap
(WebCore::Style::AnchorPositionEvaluator::updateAnchorPositioningStatesAfterInterleavedLayout):
(WebCore::Style::AnchorPositionEvaluator::isImplicitAnchor):
Parsing and style computation
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/AnchorPositionEvaluator.h:
* Source/WebCore/style/values/anchor-position/StylePositionAnchor.cpp: Copied
from Source/WebCore/style/values/anchor-position/StylePositionAnchor.h.
(WebCore::Style::CSSValueConversion<PositionAnchor>::operator):
* Source/WebCore/style/values/anchor-position/StylePositionAnchor.h:
(WebCore::Style::PositionAnchor::PositionAnchor):
(WebCore::Style::PositionAnchor::isNormal const):
(WebCore::Style::PositionAnchor::isNone const):
(WebCore::Style::PositionAnchor::isAuto const):
(WebCore::Style::PositionAnchor::isName const):
(WebCore::Style::PositionAnchor::tryName const):
(WebCore::Style::PositionAnchor::switchOn const):
Fix for failing build
* Source/WebCore/style/values/filter-effects/StyleAppleColorFilter.h:
Add new header and source file
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
# Conflicts:
# Source/WebCore/Sources.txt
Canonical link: https://commits.webkit.org/312378@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
