Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 95c755e8936a2d310aa64716ea89d226cc2702ee
https://github.com/WebKit/WebKit/commit/95c755e8936a2d310aa64716ea89d226cc2702ee
Author: Alan Baradlay <[email protected]>
Date: 2026-04-30 (Thu, 30 Apr 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/absolute-tables-height-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/absolute-tables-height-001.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Absolutely positioned table ignores max-height
https://bugs.webkit.org/show_bug.cgi?id=313607
Reviewed by Antti Koivisto.
The MaximumSize overload of computeOutOfFlowPositionedLogicalHeightUsing
had the same blanket isRenderTable() early return as PreferredSize and
MinimumSize (fixed in previous commits). This was dead code -- max-height
defaults to "none" and the caller guards with !isNone(), so this
overload is only called with specified values. But if reached, it
returned contentLogicalHeight instead of evaluating the specified
max-height.
<div style="position: relative; width: 100px; height: 50px;">
<table style="position: absolute; width: 100%;
height: 100%; max-height: 20px;">
<tr><td></td></tr>
</table>
</div>
height: 100% of 50 = 50. max-height: 20px should clamp to 20.
Before: isRenderTable() -> return contentLogicalHeight.
After: guard removed -> evaluate(20px) = 20 -> clamp.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/absolute-tables-height-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/absolute-tables-height-001.html:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeOutOfFlowPositionedLogicalHeightUsing const):
Canonical link: https://commits.webkit.org/312357@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
