Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3d1372667d1584ab687c9f7234a439d08dbb877a
https://github.com/WebKit/WebKit/commit/3d1372667d1584ab687c9f7234a439d08dbb877a
Author: Brent Fulgham <[email protected]>
Date: 2026-04-29 (Wed, 29 Apr 2026)
Changed paths:
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl
A Source/WebInspectorUI/UserInterface-input.xcfilelist
M Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj
Log Message:
-----------
Further Xcode build improvements
https://bugs.webkit.org/show_bug.cgi?id=313025
rdar://175367709
Reviewed by Elliott Williams.
This patch is a follow-up to PR #63278 that improves Xcode build phase
dependency
declarations and fixes an ImageDiff build warning.
Elliott pointed out that directory paths used as inputPaths do not introduce
dependencies
on their contents, so changes to files inside those directories would not
re-run the
script phases.
This patch also changes the `copy-user-interface-resources.pl` script to read
from the
new UserInterface-input.xcfileslist when performing its copy/build operation.
This
forces us to keep the xcfilelist up-to-date.
These steps allow the build system to recognize a no-change build for
WebInspectorUI
and skip the process entirely, rather than always performing the copy/build
operations.
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
Remove alwaysOutOfDate from "Create Versions/Current/Helpers symlink" phase
and
declare the symlink path as an output instead.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Change the "Copy modern media controls code and assets" into a
PBXCopyFilesBuildPhase
gated by platformFilters, rather than using rsync. This should allow this
step to
be skipped when files have not changed.
* Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:
(readInputFileList):
(copyFilesFromList):
* Source/WebInspectorUI/UserInterface-input.xcfilelist: Added.
Add a new script to generate the xcfilelist representing the files that
need to be
processed to generate the UI. This will make the dependency checking step
of the
build capable of recognizing when this work can be skipped.
* Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj:
Added a new "Check .xcfilelists" PBXShellScriptBuildPhase that runs when
building
against the internal SDK. This will regenerate the xcfilelist if it detects
additions
or removals from the directory.
Canonical link: https://commits.webkit.org/312305@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
