Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 51fd5236ab3f6fafe9c2cffbf518bbb8207d1374
https://github.com/WebKit/WebKit/commit/51fd5236ab3f6fafe9c2cffbf518bbb8207d1374
Author: Alberto Garcia <[email protected]>
Date: 2026-04-29 (Wed, 29 Apr 2026)
Changed paths:
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
-----------
Cherry-pick 312202@main (36c3761def82).
https://bugs.webkit.org/show_bug.cgi?id=313534
Improve libatomic test in WebKitCompilerFlags.cmake
https://bugs.webkit.org/show_bug.cgi?id=313534
Reviewed by Adrian Perez de Castro and Michael Catanzaro.
Fail immediately if the atomic source test cannot be built, even when
using libatomic.
* Source/cmake/WebKitCompilerFlags.cmake:
Canonical link: https://commits.webkit.org/312202@main
Canonical link: https://commits.webkit.org/305877.460@webkitglib/2.52
Commit: 07814fb34a55f2f76f4fe0a172d28ed5807c8862
https://github.com/WebKit/WebKit/commit/07814fb34a55f2f76f4fe0a172d28ed5807c8862
Author: Zak Ridouh <[email protected]>
Date: 2026-04-29 (Wed, 29 Apr 2026)
Changed paths:
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
-----------
Cherry-pick 312222@main (cfb69a99823a).
https://bugs.webkit.org/show_bug.cgi?id=313560
[CMake] Set --std=c++17 for the libatomic probe
https://bugs.webkit.org/show_bug.cgi?id=313560
rdar://175777090
Reviewed by Michael Catanzaro.
The atomic source test uses std::atomic<std::optional<double>>, which
requires C++17. check_cxx_source_compiles inherits the compiler's
default C++ standard, and on compilers that default to C++14 or
earlier the probe fails with "no member named 'optional' in namespace
'std'". Pre-312202@main this was silent and the build proceeded
(builtins suffice on arm64 without libatomic). 312202@main promoted
the failure to FATAL_ERROR, which broke the CMake build on those
compilers.
Set CMAKE_REQUIRED_FLAGS to --std=c++17 (the actual minimum the test
imposes) around the probe; unset() restores the previous state.
* Source/cmake/WebKitCompilerFlags.cmake:
Wrap the ATOMIC_TEST_SOURCE checks with set/unset of
CMAKE_REQUIRED_FLAGS "--std=c++17".
Canonical link: https://commits.webkit.org/312222@main
Canonical link: https://commits.webkit.org/305877.461@webkitglib/2.52
Commit: b7eabfc1efa45b94eeddc2de7c022cdfefee24cd
https://github.com/WebKit/WebKit/commit/b7eabfc1efa45b94eeddc2de7c022cdfefee24cd
Author: Adrian Perez de Castro <[email protected]>
Date: 2026-04-29 (Wed, 29 Apr 2026)
Changed paths:
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
-----------
Cherry-pick 312266@main (07ed81f30130).
https://bugs.webkit.org/show_bug.cgi?id=313560
[CMake] Use cmake_{push,pop}_check_state() in WebKitCompilerFlags.cmake
https://bugs.webkit.org/show_bug.cgi?id=313560
Reviewed by Yusuke Suzuki.
This is a follow-up to 312222@main with a small cleanup.
* Source/cmake/WebKitCompilerFlags.cmake: Use cmake_push_check_state()
and cmake_pop_check_state() consistently to ensure that variables
are restored to their original values after modifying them for tests.
Canonical link: https://commits.webkit.org/312266@main
Canonical link: https://commits.webkit.org/305877.462@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/b0e24eb7fcc8...b7eabfc1efa4
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
