Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 527346d57f8cc02763692c6b91a8a59dfbe62413
https://github.com/WebKit/WebKit/commit/527346d57f8cc02763692c6b91a8a59dfbe62413
Author: Diego De La Toba <[email protected]>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/iframe-zoom-nested-ref.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
[MacOS IOS]
imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested.html
is a flaky image diff
rdar://172508874
https://bugs.webkit.org/show_bug.cgi?id=309917
Reviewed by Sammy Gill.
This test is failing due to two timing issues:
1. The test file registers its message listener inside the load handler. Each
nested leaf.html calls top.postMessage("leaf_loaded") on its own
load event, and these messages can arrive before the main window's load
fires. When that happens, they're silently dropped and
takeScreenshot() is never called, causing a timeout.
2. The reference files have no waiting mechanism, so the test harness can
capture the screenshot before the nested iframes have finished
loading, causing flaky image failures.
Modified iframe-zoom-nested.html:
Moved the message listener registration to the top level so it's ready
immediately.
Modified iframe-zoom-nested-expected.html and iframe-zoom-nested-ref.html:
Added reftest-wait and the same message-based waiting mechanism used by the
test file.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/iframe-zoom-nested-ref.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/312232@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
