Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8af021fef543fbd1528de3f4926720e22081c9ae
https://github.com/WebKit/WebKit/commit/8af021fef543fbd1528de3f4926720e22081c9ae
Author: Yusuke Suzuki <[email protected]>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/parser/ModuleAnalyzer.cpp
M Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp
M Source/JavaScriptCore/runtime/AbstractModuleRecord.h
M Source/JavaScriptCore/runtime/Completion.cpp
M Source/JavaScriptCore/runtime/CyclicModuleRecord.cpp
M Source/JavaScriptCore/runtime/CyclicModuleRecord.h
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/JSMicrotask.cpp
M Source/JavaScriptCore/runtime/JSModuleLoader.cpp
Log Message:
-----------
[JSC] More aligning module loader to the spec
rdar://175637978
https://bugs.webkit.org/show_bug.cgi?id=313372
Reviewed by Sosuke Suzuki.
Add more spec comments to clarify the behavior, and cleaning up coding
style for setters, boolean parameters. Also reducing some unnecessary
JSPromise creations.
* Source/JavaScriptCore/jsc.cpp:
(GlobalObject::moduleLoaderImportModule):
* Source/JavaScriptCore/parser/ModuleAnalyzer.cpp:
(JSC::ModuleAnalyzer::analyze):
* Source/JavaScriptCore/runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::innerModuleEvaluation):
(JSC::AbstractModuleRecord::innerModuleLinking):
(JSC::AbstractModuleRecord::setCycleRoot):
(JSC::AbstractModuleRecord::setTopLevelCapability):
(JSC::AbstractModuleRecord::setHasTLA):
(JSC::AbstractModuleRecord::cycleRoot): Deleted.
(JSC::AbstractModuleRecord::topLevelCapability): Deleted.
(JSC::AbstractModuleRecord::hasTLA): Deleted.
* Source/JavaScriptCore/runtime/AbstractModuleRecord.h:
(JSC::AbstractModuleRecord::setAsyncEvaluationOrder):
(JSC::AbstractModuleRecord::setPendingAsyncDependencies):
(JSC::AbstractModuleRecord::asyncEvaluationOrder): Deleted.
(JSC::AbstractModuleRecord::pendingAsyncDependencies): Deleted.
* Source/JavaScriptCore/runtime/Completion.cpp:
(JSC::loadAndEvaluateModule):
(JSC::loadModule):
* Source/JavaScriptCore/runtime/CyclicModuleRecord.cpp:
(JSC::CyclicModuleRecord::link):
(JSC::CyclicModuleRecord::evaluate):
(JSC::gatherAvailableAncestors):
(JSC::CyclicModuleRecord::asyncExecutionRejected):
(JSC::CyclicModuleRecord::asyncExecutionFulfilled):
* Source/JavaScriptCore/runtime/CyclicModuleRecord.h:
(JSC::CyclicModuleRecord::setStatus):
(JSC::CyclicModuleRecord::setEvaluationError):
(JSC::CyclicModuleRecord::setDFSAncestorIndex):
(JSC::CyclicModuleRecord::status): Deleted.
(JSC::CyclicModuleRecord::evaluationError): Deleted.
(JSC::CyclicModuleRecord::dfsAncestorIndex): Deleted.
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSMicrotask.cpp:
(JSC::dynamicImportLoadSettled):
(JSC::dynamicImportEvaluateSettled):
* Source/JavaScriptCore/runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::dependencyKeysIfEvaluated):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::requestImportModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::innerModuleLoading):
Canonical link: https://commits.webkit.org/312220@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
