Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dc829e1a2e2883cbe3e903f0265351c103aed8fb
https://github.com/WebKit/WebKit/commit/dc829e1a2e2883cbe3e903f0265351c103aed8fb
Author: Simon Lewis <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformMac.cmake
M Tools/WebKitTestRunner/PlatformMac.cmake
Log Message:
-----------
[CMake][Mac] WebKitTestRunner/TestWebKitAPI/TestIPC fail to link: WTF OBJECT
library brings in unresolved bmalloc
https://bugs.webkit.org/show_bug.cgi?id=313509
Reviewed by Geoffrey Garen.
WTF and bmalloc are OBJECT libraries on the Mac port. Listing bare `WTF` in
a target's _LIBRARIES pulls every WTF .o onto the link line, which references
bmalloc symbols that aren't linked, and would also create a second copy of
WTF static state alongside JavaScriptCore.framework's (see the existing
TestRunnerInjectedBundle comment). These executables already get WTF symbols
via JavaScriptCore.framework, which re-exports them.
Drop `WTF` from the three _LIBRARIES lists. TestIPC additionally needs
JavaScriptCore (it previously had no direct link to it) and Security (which
rode in on WTF's INTERFACE), and both TestWebKit and TestIPC need
${ICU_INCLUDE_DIRS} for the same reason.
* Tools/TestWebKitAPI/PlatformMac.cmake:
* Tools/WebKitTestRunner/PlatformMac.cmake:
Canonical link: https://commits.webkit.org/312165@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
