Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fe27944650132ff04eb01d6d3f49cf65b332ef90
https://github.com/WebKit/WebKit/commit/fe27944650132ff04eb01d6d3f49cf65b332ef90
Author: Ryosuke Niwa <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M LayoutTests/http/tests/navigation/cross-site-iframe-nav.html
M LayoutTests/platform/ios-site-isolation/TestExpectations
M LayoutTests/platform/mac-site-isolation/TestExpectations
Log Message:
-----------
[Site Isolation] http/tests/navigation/cross-site-iframe-nav.html fails
https://bugs.webkit.org/show_bug.cgi?id=313454
Reviewed by Megan Gardner.
This test has a race condition with site isolation: after a back navigation,
the cross-site iframe
(in a separate process) can send its load/pageshow messages to the opener
before the popup's own
load/pageshow event arrives, producing non-deterministic debug output ordering.
This PR fixes the opener page. When other.pageshow fires (triggering back1), it
enters a collection
phase via startWaitingForBack1(). During this phase, popup.load,
popup.pageshow, crosssite.load,
and crosssite.pageshow (count 2) all suppress their normal output and instead
record into
back1ExpectedEvents. Once both popup and crosssite pageshow events have been
received,
recordBack1Event outputs all debug lines in the expected deterministic order —
popup events first,
then crosssite events — and proceeds with back2, thereby fixing the failure
under site isolation.
Co-authored with Claude.
* LayoutTests/http/tests/navigation/cross-site-iframe-nav.html:
* LayoutTests/platform/ios-site-isolation/TestExpectations:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
Canonical link: https://commits.webkit.org/312126@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
