Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 41ae266227a4545cf68e6571a1c1cb961ca3aefe
https://github.com/WebKit/WebKit/commit/41ae266227a4545cf68e6571a1c1cb961ca3aefe
Author: Simon Lewis <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M Source/JavaScriptCore/b3/air/opcode_generator.rb
M Source/JavaScriptCore/create_hash_table
M Source/JavaScriptCore/wasm/generateWasm.py
M Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py
Log Message:
-----------
[JSC] Codegen: emit basenames, not absolute paths, in "generated from"
comments
https://bugs.webkit.org/show_bug.cgi?id=313430
Reviewed by Yusuke Suzuki.
create_hash_table, opcode_generator.rb, generateWasm.py and
generateYarrUnicodePropertyTables.py each write a header comment of the
form "Automatically generated from <abs path to source> using <abs path
to script>". The paths come from $0/ARGV/__file__ and are absolute
because cmake invokes the generators with absolute arguments.
ccache's CCACHE_BASEDIR rewrites absolute paths on the compiler command
line and in depfiles, but not inside file *contents*. So two worktrees
of the same commit produce 80+ DerivedSources headers that differ only
in this comment, and every JSC TU that includes one (which is nearly all
of them via Lookup.h / WasmOps.h / AirOpcode.h) is a cross-worktree
cache miss.
Emit only the basename. The comment stays useful for finding the
generator; the output is byte-identical across worktrees.
* Source/JavaScriptCore/create_hash_table:
* Source/JavaScriptCore/b3/air/opcode_generator.rb:
* Source/JavaScriptCore/wasm/generateWasm.py:
* Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py:
Canonical link: https://commits.webkit.org/312121@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
