Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ba55759b9349346c46573cb9c97aba5cc1aed80c
https://github.com/WebKit/WebKit/commit/ba55759b9349346c46573cb9c97aba5cc1aed80c
Author: Geoffrey Garen <[email protected]>
Date: 2026-04-27 (Mon, 27 Apr 2026)
Changed paths:
M CMakePresets.json
M Source/ThirdParty/libwebrtc/CMakeLists.txt
M Source/WebCore/PlatformMac.cmake
M Source/cmake/OptionsMac.cmake
M Source/cmake/WebKitCommon.cmake
M Source/cmake/WebKitMacros.cmake
M Tools/Scripts/swift/swiftc-wrapper.sh
M Tools/TestWebKitAPI/Tests/WebKit/WKPage/DOMWindowExtensionBasic_Bundle.cpp
M
Tools/TestWebKitAPI/Tests/WebKit/WKPage/DOMWindowExtensionNoCache_Bundle.cpp
M Tools/clangd/update-compile-commands-symlink
M Tools/clangd/update-compile-commands-symlink.conf.example
Log Message:
-----------
Fixed the CMake Swift build with recent toolchains
https://bugs.webkit.org/show_bug.cgi?id=313294
rdar://175562562
Reviewed by David Kilzer and Charlie Wolfe.
* CMakePresets.json: Turn off experimental features on all configs because they
don't build cleanly.
* Source/ThirdParty/libwebrtc/CMakeLists.txt: Add missing files to address
a linker issue.
* Source/WebCore/Headers.cmake: Fix the header listing regression from
d801bd01eb61.
* Source/WebCore/PlatformMac.cmake: Fix the header include regression from
95a3f2348f1e.
* Source/cmake/OptionsMac.cmake: Support invoking the Swift compiler with a
toolchain version that doesn't match your OS version.
* Source/cmake/WebKitCommon.cmake: Don't run the symlink step every build; only
run when out of date.
* Source/cmake/WebKitMacros.cmake: Don't enable -Werror for all errors at once
because then the "no unsafe operations occur within unsafe expression" fails
the build.
Instead, enable the specific errors we enable in Xcode.
* Tools/Scripts/swift/swiftc-wrapper.sh: Silence the "no unsafe operations..."
warning text to clean up build output.
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
(TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/DOMWindowExtensionNoCache_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
(TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage): Took the
opportunity to clean up this snprintf shmutz in the build output too.
* Tools/clangd/update-compile-commands-symlink:
(update_symlink_with_path): Handle both the CMake and Xcode case by removing
the old
symlink or file unconditionally.
* Tools/clangd/update-compile-commands-symlink.conf.example: Updated to match
our
recommended presets.
Canonical link: https://commits.webkit.org/312109@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
