Title: [114721] trunk
- Revision
- 114721
- Author
- [email protected]
- Date
- 2012-04-19 23:58:15 -0700 (Thu, 19 Apr 2012)
Log Message
[EFL] Missing keycode translation for space key
https://bugs.webkit.org/show_bug.cgi?id=84153
Patch by Sudarsana Nagineni <[email protected]> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebCore:
Map space key to Unicode value in createKeyMap(), and also set
correct keyname 'space' for space key in createWindowsKeyMap().
Tests: fast/html/details-keyboard-show-hide.html
fast/forms/button-spacebar-click.html
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
Tools:
Set keyname for space key before dispatching event.
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue):
LayoutTests:
Unskip tests connected with space key.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (114720 => 114721)
--- trunk/LayoutTests/ChangeLog 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/LayoutTests/ChangeLog 2012-04-20 06:58:15 UTC (rev 114721)
@@ -1,3 +1,14 @@
+2012-04-19 Sudarsana Nagineni <[email protected]>
+
+ [EFL] Missing keycode translation for space key
+ https://bugs.webkit.org/show_bug.cgi?id=84153
+
+ Reviewed by Antonio Gomes.
+
+ Unskip tests connected with space key.
+
+ * platform/efl/Skipped:
+
2012-04-19 Antaryami Pandia <[email protected]>
Inserting empty html moves caret.
Modified: trunk/LayoutTests/platform/efl/Skipped (114720 => 114721)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-20 06:58:15 UTC (rev 114721)
@@ -1280,7 +1280,6 @@
fast/events/keydown-numpad-keys.html
fast/events/option-tab.html
fast/events/special-key-events-in-input-text.html
-fast/forms/button-spacebar-click.html
fast/forms/enter-clicks-buttons.html
fast/forms/input-search-press-escape-key.html
@@ -1877,7 +1876,6 @@
fast/gradients/radial-centered.html
fast/harness/user-preferred-language.html
fast/html/details-click-controls.html
-fast/html/details-keyboard-show-hide.html
fast/html/marquee-alternate.html
fast/inline-block/contenteditable-baseline.html
fast/inline/continuation-outlines-with-layers-2.html
Modified: trunk/Source/WebCore/ChangeLog (114720 => 114721)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 06:58:15 UTC (rev 114721)
@@ -1,3 +1,19 @@
+2012-04-19 Sudarsana Nagineni <[email protected]>
+
+ [EFL] Missing keycode translation for space key
+ https://bugs.webkit.org/show_bug.cgi?id=84153
+
+ Reviewed by Antonio Gomes.
+
+ Map space key to Unicode value in createKeyMap(), and also set
+ correct keyname 'space' for space key in createWindowsKeyMap().
+
+ Tests: fast/html/details-keyboard-show-hide.html
+ fast/forms/button-spacebar-click.html
+
+ * platform/efl/EflKeyboardUtilities.cpp:
+ (WebCore::createKeyMap):
+
2012-04-19 Antaryami Pandia <[email protected]>
Inserting empty html moves caret.
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (114720 => 114721)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-04-20 06:58:15 UTC (rev 114721)
@@ -77,6 +77,7 @@
keyMap().set("Tab", "U+0009");
keyMap().set("ISO_Left_Tab", "U+0009");
keyMap().set("BackSpace", "U+0008");
+ keyMap().set("space", "U+0020");
}
static void createWindowsKeyMap()
@@ -99,7 +100,7 @@
windowsKeyMap().set("Tab", VK_TAB);
windowsKeyMap().set("ISO_Left_Tab", VK_TAB);
windowsKeyMap().set("BackSpace", VK_BACK);
- windowsKeyMap().set("Space", VK_SPACE);
+ windowsKeyMap().set("space", VK_SPACE);
windowsKeyMap().set("Next", VK_NEXT);
windowsKeyMap().set("Prior", VK_PRIOR);
windowsKeyMap().set("Home", VK_HOME);
Modified: trunk/Tools/ChangeLog (114720 => 114721)
--- trunk/Tools/ChangeLog 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/Tools/ChangeLog 2012-04-20 06:58:15 UTC (rev 114721)
@@ -1,3 +1,15 @@
+2012-04-19 Sudarsana Nagineni <[email protected]>
+
+ [EFL] Missing keycode translation for space key
+ https://bugs.webkit.org/show_bug.cgi?id=84153
+
+ Reviewed by Antonio Gomes.
+
+ Set keyname for space key before dispatching event.
+
+ * DumpRenderTree/efl/EventSender.cpp:
+ (keyNameFromJSValue):
+
2012-04-19 Carlos Garcia Campos <[email protected]>
[GTK] Allow to use WebInspector in GtkLauncher
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (114720 => 114721)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-04-20 06:47:52 UTC (rev 114720)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-04-20 06:58:15 UTC (rev 114721)
@@ -406,6 +406,8 @@
return "Tab";
if (charCode == '\x8')
return "BackSpace";
+ if (charCode == ' ')
+ return "space";
return character->ustring().utf8();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
