Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af29d7b1edd959d5d505be847d20f4693c1b3c04
      
https://github.com/WebKit/WebKit/commit/af29d7b1edd959d5d505be847d20f4693c1b3c04
  Author: Kimmo Kinnunen <[email protected]>
  Date:   2026-04-22 (Wed, 22 Apr 2026)

  Changed paths:
    M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/gen_mtl_format_table.py
    M 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.mm

  Log Message:
  -----------
  ANGLE: Metal: 
ImageTestMetal.OverrideMetalTextureInternalFormatIncompatibleFormat fails 
validation
https://bugs.webkit.org/show_bug.cgi?id=312875
rdar://175238170

Reviewed by Dan Glastonbury.

Format::isViewCompatible(const Format &srcFormat)  would compare
    if (srcFormat.caps.channels != caps.channels) ..
    if (srcFormat.caps.pixelBytes != caps.pixelBytes) ..

These properties were not populated at all.
Make the generator extract the info from MTLPixelFormatXXX names.

* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/gen_mtl_format_table.py:
(is_format_deprecated):
(is_format_compressed):
(get_mtl_format_channels_and_bytes):
(gen_mtl_format_caps_init_string):
(gen_mtl_format_caps_init_string.caps_to_cpp):
(gen_mtl_format_caps_init_string.cap_to_param): Deleted.
* 
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
(rx::mtl::FormatTable::initNativeFormatCapsAutogen):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.mm:
(rx::mtl::FormatTable::setFormatCaps):
(rx::mtl::FormatTable::setCompressedFormatCaps): Deleted.

Canonical link: https://commits.webkit.org/311827@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to