Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b57d6ca3ffb338d47ab7414d97182dc287064c48
https://github.com/WebKit/WebKit/commit/b57d6ca3ffb338d47ab7414d97182dc287064c48
Author: Anne van Kesteren <[email protected]>
Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-lines.test
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/comment-in-cue-text.html
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-lines-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-lines.html
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-line-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-lines.vtt
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tools/build.py
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/html/track/VTTRegion.cpp
M Source/WebCore/html/track/VTTScanner.cpp
M Source/WebCore/html/track/VTTScanner.h
M Source/WebCore/html/track/WebVTTParser.cpp
M Source/WebCore/html/track/WebVTTParser.h
Log Message:
-----------
Address WebVTT settings line parsing failures
https://bugs.webkit.org/show_bug.cgi?id=312720
Reviewed by Chris Dumez.
When parsing the settings line number we should use a double, require a
digit on both sides of the dot (if any), not cast to int, and not allow
-0 through.
We also update the regions line test here as it was incorrect
(VTTRegion uses unsigned long for its lines member).
We also remove comments that are no longer aligned with the current
specification and did not seem particularly helpful.
Upstream changes:
https://github.com/web-platform-tests/wpt/pull/59335
Canonical link: https://commits.webkit.org/311729@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
