Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4c334d3b96b00674f9cacce1df7a59ca852d1649
https://github.com/WebKit/WebKit/commit/4c334d3b96b00674f9cacce1df7a59ca852d1649
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h
Log Message:
-----------
REGRESSION(311425@main) [GLIB] Flaky view-transition test crashes
https://bugs.webkit.org/show_bug.cgi?id=312629
Reviewed by Nikolas Zimmermann.
The problem is that in ThreadedCompositor renderLayerTree can be called
after invalidate. Before 311425@main we returned early because m_context
is also set to nullptr in invalidate, but now the context is always
nullptr when using skia compositor and we are assuming that a null
texture mapper means we are using skia. This patch adds an Invalidated state
to ThreadedCompositor to make sure we always return early from
renderLayerTree after invalidate, and it always uses m_useSkia to check
if we are using the skia compositor.
Fixes:
imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pageswap-push-with-redirect.html
imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pageswap-skip-transition.html
imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pageswap-replace-navigation.html
imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pagereveal-with-view-transition.html
* LayoutTests/platform/glib/TestExpectations:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::isActive const):
(WebKit::ThreadedCompositor::paintToCurrentGLContext):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::stateToString):
(WebKit::ThreadedCompositor::scheduleUpdateLocked):
(WebKit::ThreadedCompositor::frameComplete):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h:
Canonical link: https://commits.webkit.org/311654@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
