Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b4caee3eb24f6cfebb97b426d153ab77d2c7a806
https://github.com/WebKit/WebKit/commit/b4caee3eb24f6cfebb97b426d153ab77d2c7a806
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M Tools/TestWebKitAPI/Resources/cocoa/element-fullscreen.html
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FullscreenVideoTextRecognition.mm
Log Message:
-----------
REGRESSION (256320@main?): [iOS] 2
TestWebKitAPI.FullscreenVideoTextRecognition tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=248094
rdar://102522560
Reviewed by Eric Carlson.
The tests AddVideoAfterEnteringFullscreen and
DoNotAnalyzeVideoAfterExitingFullscreen were failing on iOS as
video.play() triggered automatic entry into native video fullscreen via the
HAVE(AVEXPERIENCECONTROLLER) path in
MediaElementSession::requiresFullscreenForVideoPlayback().
This caused DoNotAnalyzeVideoAfterExitingFullscreen to fail because after
exiting element fullscreen,
playing the video would re-enter native video fullscreen, and the subsequent
pause would correctly
trigger text recognition in that new fullscreen context — violating the test's
expectation.
Fixed by adding playsinline to the video element in element-fullscreen.html and
setting allowsInlineMediaPlayback =
YES on the test's WKWebViewConfiguration, ensuring the video plays inline
rather than automatically entering native
video fullscreen on iOS.
* Tools/TestWebKitAPI/Resources/cocoa/element-fullscreen.html:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FullscreenVideoTextRecognition.mm:
(+[FullscreenVideoTextRecognitionWebView create]):
(TestWebKitAPI::TEST(FullscreenVideoTextRecognition,
AddVideoAfterEnteringFullscreen)):
(TestWebKitAPI::TEST(FullscreenVideoTextRecognition,
DoNotAnalyzeVideoAfterExitingFullscreen)):
Canonical link: https://commits.webkit.org/311627@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
