Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 872682a8604774842dcd1fd4af6484b512c2871b
https://github.com/WebKit/WebKit/commit/872682a8604774842dcd1fd4af6484b512c2871b
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/Model/MeshImpl.cpp
M Source/WebKit/GPUProcess/graphics/Model/MeshImpl.h
M Source/WebKit/GPUProcess/graphics/Model/ModelBridge.swift
M Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.cpp
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.h
M Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.messages.in
M Source/WebKit/GPUProcess/graphics/Model/USDModel.swift
M Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.h
M Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm
M Source/WebKit/Shared/Model.serialization.in
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h
M Source/WebKit/WebProcess/Model/Mesh.h
M Source/WebKit/WebProcess/Model/ModelInlineConverters.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
[model] WebKit is not using mip level information from the texture updates
https://bugs.webkit.org/show_bug.cgi?id=311843
rdar://174433382
Reviewed by Dan Glastonbury.
Instead of relying on linearly packed texture data from USDStageKit,
which does not appear to be guaranteed, use the TextureLevelInfo data
and pass over IPC.
* Source/WebKit/GPUProcess/graphics/Model/MeshImpl.cpp:
(WebKit::MeshImpl::setEnvironmentMap):
* Source/WebKit/GPUProcess/graphics/Model/MeshImpl.h:
* Source/WebKit/GPUProcess/graphics/Model/ModelBridge.swift:
* Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h:
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.cpp:
(WebKit::RemoteMesh::setEnvironmentMap):
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.h:
* Source/WebKit/GPUProcess/graphics/Model/RemoteMesh.messages.in:
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(updateTexture(_:)):
(setEnvironmentMap(_:)):
(webUpdateTextureRequestFromUpdateTextureRequest(_:)):
(USDModelLoader.loadEnvironmentMap(_:)):
(WKBridgeModelLoader.loadEnvironmentMap(_:)):
(WKBridgeReceiver.setEnvironmentMap(_:)):
* Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.h:
* Source/WebKit/GPUProcess/graphics/Model/WebKitMesh.mm:
(WebModel::convert):
(WebKit::convert):
(WebKit::WebMesh::setEnvironmentMap):
* Source/WebKit/Shared/Model.serialization.in:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.cpp:
(WebKit::RemoteMeshProxy::setEnvironmentMap):
* Source/WebKit/WebProcess/GPU/graphics/Model/RemoteMeshProxy.h:
* Source/WebKit/WebProcess/Model/Mesh.h:
* Source/WebKit/WebProcess/Model/ModelInlineConverters.h:
(WebKit::convert):
(WebKit::toCpp): Deleted.
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::load):
(WebKit::WebModelPlayer::setEnvironmentMap):
(WebKit::computePixelFormat): Deleted.
(WebKit::loadIBL): Deleted.
Canonical link: https://commits.webkit.org/311616@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
