Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2566042879a7a34fbbbfd4bf962d92b32120e711
https://github.com/WebKit/WebKit/commit/2566042879a7a34fbbbfd4bf962d92b32120e711
Author: Alicia Boya Garcia <[email protected]>
Date: 2026-04-20 (Mon, 20 Apr 2026)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
Log Message:
-----------
[GStreamer] Report support for supported non-AAC mp4a codecs
https://bugs.webkit.org/show_bug.cgi?id=312501
Reviewed by Xabier Rodriguez-Calvar.
https://commits.webkit.org/310634@main made it so that we no longer mark
all codec strings starting with "mp4a." as supported the moment we find
an MPEG-4 AAC decoder, instead allowing only the specific codec strings
used by AAC.
There are however other audio codec that use strings that start with
"mp4a.", that were already working, and for which WebKit reported
support, even if only accidentally due to finding an AAC decoder.
Notably, this the case for MP3 (mp4a.6b and mp4a.69), AC-3 (mp4a.a5) and
EAC-3 (mp4a.a6). This regression was identified with the MVT test suite:
https://github.com/rdkcentral/MVT
This patch adds those codec strings to GStreamerRegistryScanner when
appropriate decoders are found, both fixing the regression and ensuring
support is not reported accidentally.
Previously the code for initializeDecoders() implied MPEG-1 and MPEG-2
audio is not supported with MSE, even though it was already working and
reported as supported. This patch moves the support check code to the
part of the function common for both MSE and non-MSE.
Support for mp4a.67 has been moved to the check for audio/mpeg,
mpegversion=2. Although in practice virtually all AAC decoders will
support both mpegversion=2 and mpegversion=4, this is the technically
correct place for it.
As a drive-by fix, the logging in GStreamerRegistryScanner::refresh()
has been fixed: all codecs were being reported as being hardware-based
due to leftovers from a refactor.
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::refresh):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
Canonical link: https://commits.webkit.org/311571@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
