Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d399725cdc64ea33a7e8d6bc96d658866edbc0ae
https://github.com/WebKit/WebKit/commit/d399725cdc64ea33a7e8d6bc96d658866edbc0ae
Author: Brady Eidson <[email protected]>
Date: 2026-04-12 (Sun, 12 Apr 2026)
Changed paths:
M Tools/TestWebKitAPI/Helpers/cocoa/CGImagePixelReader.cpp
M Tools/TestWebKitAPI/Helpers/cocoa/DaemonTestUtilities.mm
M Tools/TestWebKitAPI/Helpers/cocoa/HTTPServer.mm
M Tools/TestWebKitAPI/Helpers/cocoa/TestProtocol.mm
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
M Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp
M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp
M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp
M Tools/TestWebKitAPI/Tests/WTF/cf/StringCF.cpp
M Tools/TestWebKitAPI/Tests/WTF/cf/VectorCF.cpp
M Tools/TestWebKitAPI/Tests/WTF/cocoa/ContextualizedNSString.mm
M Tools/TestWebKitAPI/Tests/WTF/cocoa/RetainPtr.mm
M Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm
M Tools/TestWebKitAPI/Tests/WTF/darwin/TypeCastsOSObjectCF.cpp
M Tools/TestWebKitAPI/Tests/WebCore/MonospaceFontTests.cpp
M
Tools/TestWebKitAPI/Tests/WebCore/cocoa/BifurcatedGraphicsContextTestsCG.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/CoreMediaUtilities.mm
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/GraphicsContextCGTests.mm
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKPage/cocoa/XPCEndpoint.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ApplicationManifest.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Challenge.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EditorStateTests.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EventAttribution.mm
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FirstVisuallyNonEmptyMilestone.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/GPUProcess.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/IPCTestingAPI.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/PDFLinkReferrer.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ServiceWorkerBasic.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextWidth.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewSnapshot.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewThemeColor.mm
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewUnderPageBackgroundColor.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WebPushDaemon.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKWebAuthenticationPanel.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/DragAndDropTestsIOS.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/TextStyleFontSize.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/WKScrollViewTests.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/BackgroundColor.mm
M
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/MediaPlaybackSleepAssertion.mm
M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm
M Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/WebThreadLock.mm
Log Message:
-----------
Bring TestWebKitAPI up to code with regard to adoptRef, adoptCF, and
adoptOSObject
rdar://174609096
https://bugs.webkit.org/show_bug.cgi?id=312100
Reviewed by Richard Robinson.
In https://commits.webkit.org/311010@main I replaced all uses of `auto` with
`adoptNS` in TestWebKitAPI
to bring them up to the new coding style guidelines.
It's bugging me that I didn't go adoptCF, adoptRef, and adoptOSObject as well.
So here we are.
* Tools/TestWebKitAPI/Helpers/cocoa/CGImagePixelReader.cpp:
(TestWebKitAPI::CGImagePixelReader::CGImagePixelReader):
* Tools/TestWebKitAPI/Helpers/cocoa/DaemonTestUtilities.mm:
(TestWebKitAPI::convertArrayToXPC):
(TestWebKitAPI::convertDictionaryToXPC):
* Tools/TestWebKitAPI/Helpers/cocoa/HTTPServer.mm:
(TestWebKitAPI::proxyDefinition):
* Tools/TestWebKitAPI/Helpers/cocoa/TestProtocol.mm:
(contentTypeForFileExtension):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(createCertificate):
(createPrivateKey):
(TEST(IPCSerialization, Basic)):
(fakeDataDetectorResultForTesting):
(TEST(CoreIPCCFDictionary, InsertDifferentValueTypes)):
(TEST(CoreIPCCFDictionary, InsertDifferentKeyTypes)):
* Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::ListHashSetReferencedItem::create):
* Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp:
(TestWebKitAPI::TEST(NativePromise, AsyncResolve)):
(TestWebKitAPI::TEST(NativePromise, CompletionPromises)):
* Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST(WTF_ThreadSafeWeakPtr, UseAfterMoveResistance)):
(TestWebKitAPI::TEST(WTF_ThreadSafeWeakPtr,
ThreadSafeWeakHashAmortizedCleanupWhenOnlyAdding)):
(TestWebKitAPI::TEST(WTF_ThreadSafeWeakPtr, AmortizedCleanupNotQuadratic)):
(TestWebKitAPI::TEST(WTF_ThreadSafeWeakPtr, MultipleInheritance)):
* Tools/TestWebKitAPI/Tests/WTF/cf/StringCF.cpp:
(TestWebKitAPI::TEST(StringCF, ConstructFromLatin1WithHighBytes)):
(TestWebKitAPI::TEST(StringCF, ConstructFromUTF16WithLatin1Characters)):
(TestWebKitAPI::TEST(StringCF, ConstructFromUTF16WithHighLatin1Characters)):
(TestWebKitAPI::TEST(StringCF, ConstructFromUTF16WithNonLatin1Characters)):
(TestWebKitAPI::TEST(StringCF, ConstructFromUTF16MixedLatin1AndNonLatin1)):
* Tools/TestWebKitAPI/Tests/WTF/cf/VectorCF.cpp:
(TestWebKitAPI::TEST(VectorCF, MakeVector_CFString)):
(TestWebKitAPI::TEST(VectorCF, MakeVector_CFNumber)):
(TestWebKitAPI::TEST(VectorCF, MakeVectorWithFunctor)):
(TestWebKitAPI::TEST(VectorCF, VectorFromCFData)):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/ContextualizedNSString.mm:
(TEST(WTF_ContextualizedNSString, tokenizer)):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/RetainPtr.mm:
(TestWebKitAPI::TEST(RETAIN_PTR_TEST_NAME, HashMapCFTypeDeletedValue)):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
(TestWebKitAPI::TEST(TypeCastsCocoa, bridge_id_cast)):
* Tools/TestWebKitAPI/Tests/WTF/darwin/TypeCastsOSObjectCF.cpp:
(TestWebKitAPI::TEST(TypeCastsOSObjectCF, osObjectCast)):
(TestWebKitAPI::TEST(TypeCastsOSObjectCF, dynamicOSObjectCast)):
(TestWebKitAPI::TEST(TypeCastsOSObjectCF, dynamicOSObjectCast_OSObjectPtr)):
(TestWebKitAPI::TEST(TypeCastsOSObjectCF,
dynamicOSObjectCast_const_OSObjectPtr)):
* Tools/TestWebKitAPI/Tests/WebCore/MonospaceFontTests.cpp:
(TestWebKitAPI::TEST(MonospaceFontsTest, EnsureMonospaceFontInvariants)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/BifurcatedGraphicsContextTestsCG.cpp:
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, Basic)):
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, DrawTiledGradientImage)):
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, DrawGradientImage)):
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, Borders)):
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, TransformedClip)):
(TestWebKitAPI::TEST(BifurcatedGraphicsContextTests, ApplyDeviceScaleFactor)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/CoreMediaUtilities.mm:
(TestWebKitAPI::makeFormatDescriptionWithTencData):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/GraphicsContextCGTests.mm:
(TestWebKitAPI::greenImage):
(TestWebKitAPI::TEST(GraphicsContextTests,
DrawNativeImageDoesNotLeakCompositeOperator)):
(TestWebKitAPI::TEST(GraphicsContextTests,
CGBitmapRenderingModeIsUnaccelerated)):
(TestWebKitAPI::TEST(GraphicsContextTests,
IOSurfaceRenderingModeIsAccelerated)):
(TestWebKitAPI::TEST(GraphicsContextTests, DrawsReportHasDrawn)):
(TestWebKitAPI::TEST(GraphicsContextTests, OutOfGamutSRGBNotDrawn)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:
(TestWebKitAPI::WebCore::TestedGraphicsContextGLCocoa::create):
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/cocoa/XPCEndpoint.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ApplicationManifest.mm:
(TestWebKitAPI::TEST(ApplicationManifest, Coding)):
(TestWebKitAPI::TEST(ApplicationManifest, Basic)):
(TestWebKitAPI::TEST(ApplicationManifest, AlwaysFetchData)):
(TestWebKitAPI::TEST(ApplicationManifest, OnlyFirstManifest)):
(TestWebKitAPI::TEST(ApplicationManifest, MediaAttriute)):
(TestWebKitAPI::TEST(ApplicationManifest, Icons)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Challenge.mm:
(createTestIdentity):
(verifyCertificateAndPublicKey):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EditorStateTests.mm:
(TestWebKitAPI::TEST(EditorStateTests, CaretColorInContentEditable)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/EventAttribution.mm:
(TestWebKitAPI::signUnlinkableTokenAndSendSecretToken):
(TestWebKitAPI::attemptConnectionInProcessWithoutEntitlement):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/FirstVisuallyNonEmptyMilestone.mm:
(contentTypeForFileExtension):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/GPUProcess.mm:
(TestWebKitAPI::TEST(GPUProcess, CanvasBasicCrashHandling)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/IPCTestingAPI.mm:
(CGColorInNSSecureCoding)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/PDFLinkReferrer.mm:
(createPDFWithLinkToURL):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ServiceWorkerBasic.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ThemeColor)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextWidth.mm:
(TEST(WebKit, TextWidth)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewSnapshot.mm:
(TestWebKitAPI::TEST(WKWebView, SnapshotImageBaseCase)):
(TestWebKitAPI::TEST(WKWebView, SnapshotImageLargeAsyncDecoding)):
(TestWebKitAPI::TEST(WKWebView, SnapshotAfterScreenUpdates)):
(TestWebKitAPI::TEST(WKWebView, SnapshotWithoutAfterScreenUpdates)):
(TestWebKitAPI::TEST(WKWebView, SnapshotWebGL)):
(TestWebKitAPI::TEST(WKWebView, SnapshotWithoutSelectionHighlighting)):
(TestWebKitAPI::TEST(WKWebView, SnapshotWithContentsRect)):
(TestWebKitAPI::TEST(WKWebView, RemoteSnapshotWithTransform)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewThemeColor.mm:
(TEST(WKWebViewThemeColor, MetaElementValidNameAndColor)):
(TEST(WKWebViewThemeColor, MetaElementValidNameAndColorAndMedia)):
(TEST(WKWebViewThemeColor, MetaElementInvalidName)):
(TEST(WKWebViewThemeColor, MetaElementInvalidColor)):
(TEST(WKWebViewThemeColor, MetaElementInvalidMedia)):
(TEST(WKWebViewThemeColor, MetaElementMultipleValid)):
(TEST(WKWebViewThemeColor, MetaElementValidSubframe)):
(TEST(WKWebViewThemeColor, KVO)):
(TEST(WKWebViewThemeColor, ApplicationManifest)):
(TEST(WKWebViewThemeColor, MetaElementOverridesApplicationManifest)):
*
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewUnderPageBackgroundColor.mm:
(defaultBackgroundColor):
(TEST(WKWebViewUnderPageBackgroundColor, SingleSolidColor)):
(TEST(WKWebViewUnderPageBackgroundColor, MultipleSolidColors)):
(TEST(WKWebViewUnderPageBackgroundColor, KVO)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WebPushDaemon.mm:
(TestWebKitAPI::WebPushXPCConnectionMessageSender::messageDictionaryFromEncoder
const):
(TestWebKitAPI::createAndConfigureConnectionToService):
(TestWebKitAPI::TEST(WebPushD, BasicCommunication)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::WebCore::addKeyToKeychain):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::isCompletelyWhite):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/TextStyleFontSize.mm:
(TEST(TextStyleFontSize, Startup)):
(TEST(TextStyleFontSize, AfterCrash)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ios/WKScrollViewTests.mm:
(TestWebKitAPI::(WKScrollViewTests, BackgroundColorSetByClient)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/BackgroundColor.mm:
(TestWebKitAPI::TEST(WebKit, BackgroundColorToggleAppearance)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/MediaPlaybackSleepAssertion.mm:
(TestWebKitAPI::hasAssertionType):
* Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
(TestWebKitAPI::TEST(WebKitLegacy, RenderInContextSnapshot)):
* Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/WebThreadLock.mm:
(TestWebKitAPI::TEST(WebKitLegacy,
NestedRunLoopUnderRunLoopObserverDoubleUnlock)):
Canonical link: https://commits.webkit.org/311046@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
