Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: edd693e4bb6fd680b9a0f7bcf5b5bca14c190038
https://github.com/WebKit/WebKit/commit/edd693e4bb6fd680b9a0f7bcf5b5bca14c190038
Author: Chris Dumez <[email protected]>
Date: 2026-04-11 (Sat, 11 Apr 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/consume-user-activation/window-open-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/consume-user-activation/window-open.html
M
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin-expected.txt
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/page/LocalDOMWindow.cpp
Log Message:
-----------
window.open() should consume user activation when creating a new browsing
context
https://bugs.webkit.org/show_bug.cgi?id=312035
Reviewed by Darin Adler.
Per the HTML spec "the rules for choosing a navigable", opening a new window via
window.open() should consume user activation. Opening an existing named window
should not. WebKit was not consuming activation in either case.
Test:
imported/w3c/web-platform-tests/html/browsers/windows/consume-user-activation/window-open.html
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/consume-user-activation/window-open-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/consume-user-activation/window-open.html:
Added.
Pull the relevant WPT test from upstream. This test was failing in
shipping Safari but is passing in Chrome and Firefox.
*
LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin-expected.txt:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::createWindow):
Canonical link: https://commits.webkit.org/311026@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
