Title: [114469] trunk/Tools
Revision
114469
Author
[email protected]
Date
2012-04-17 17:29:24 -0700 (Tue, 17 Apr 2012)

Log Message

build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213

Reviewed by Eric Seidel.

Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.

* Scripts/webkitdirs.pm:
(determineIsChromiumNinja):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (114468 => 114469)


--- trunk/Tools/ChangeLog	2012-04-18 00:24:06 UTC (rev 114468)
+++ trunk/Tools/ChangeLog	2012-04-18 00:29:24 UTC (rev 114469)
@@ -1,3 +1,16 @@
+2012-04-17  Dirk Pranke  <[email protected]>
+
+        build-webkit: make ninja work with chromium linux
+        https://bugs.webkit.org/show_bug.cgi?id=84213
+
+        Reviewed by Eric Seidel.
+
+        Fix typos so that build-webkit will use ninja to
+        build chromium if a build.ninja file exists and is up-to-date.
+
+        * Scripts/webkitdirs.pm:
+        (determineIsChromiumNinja):
+
 2012-04-17  Ojan Vafai  <[email protected]>
 
         Add caching to the flakiness dashboard json files

Modified: trunk/Tools/Scripts/webkitdirs.pm (114468 => 114469)


--- trunk/Tools/Scripts/webkitdirs.pm	2012-04-18 00:24:06 UTC (rev 114468)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-04-18 00:29:24 UTC (rev 114469)
@@ -1156,7 +1156,7 @@
 
     my $hasUpToDateNinjabuild = 0;
     if (-e "out/$config/build.ninja") {
-        my $statNinja = stat("out/$config/build.ninja");
+        my $statNinja = stat("out/$config/build.ninja")->mtime;
 
         my $statXcode = 0;
         if (-e 'Source/WebKit/chromium/WebKit.xcodeproj') {
@@ -1165,7 +1165,7 @@
 
         my $statMake = 0;
         if (-e 'Makefile.chromium') {
-          $statXcode = stat('Makefile.chromium')->mtime;
+          $statMake = stat('Makefile.chromium')->mtime;
         }
 
         $hasUpToDateNinjabuild = $statNinja > $statXcode && $statNinja > $statMake;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to