Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d34a8b84cbc1563a7c4547b9e93fc73fe862e560
https://github.com/WebKit/WebKit/commit/d34a8b84cbc1563a7c4547b9e93fc73fe862e560
Author: Megan Gardner <[email protected]>
Date: 2026-03-22 (Sun, 22 Mar 2026)
Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/TextAnimationTypes.serialization.in
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
A Source/WebKit/UIProcess/Cocoa/WKTextEffectManager.h
A Source/WebKit/UIProcess/Cocoa/WKTextEffectManager.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebPageProxyInternals.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
Add WKTextEffectManager and associated plumbing for refactoring to use modern
text effects.
https://bugs.webkit.org/show_bug.cgi?id=310459
rdar://173093588
Reviewed by Wenson Hsieh.
Refactoring to use the text effects that became
available after the first implementation of
writing tools.
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/TextAnimationTypes.serialization.in:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _addTextEffectForID:withData:]):
(-[WKWebView _removeTextEffectForID:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::addTextEffectForID):
(WebKit::PageClientImplCocoa::removeTextEffectForID):
* Source/WebKit/UIProcess/Cocoa/WKTextEffectManager.h: Added.
* Source/WebKit/UIProcess/Cocoa/WKTextEffectManager.mm: Added.
(toTextEffectWritingDirection):
(-[WKTextEffectManager initWithWebView:]):
(-[WKTextEffectManager addTextEffectForID:withData:]):
(-[WKTextEffectManager removeTextEffectForID:]):
(-[WKTextEffectManager removeAllTextEffects]):
(-[WKTextEffectManager hideTextForSuggestionWithUUID:completion:]):
(-[WKTextEffectManager showTextForSuggestionWithUUID:completion:]):
(-[WKTextEffectManager containerViewForSuggestionWithUUID:completion:]):
(textPreviewsFromIndicator):
(-[WKTextEffectManager previewsForSuggestionWithUUID:completion:]):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addTextEffectForID):
(WebKit::WebPageProxy::removeTextEffectForID):
(WebKit::WebPageProxy::updateUnderlyingTextVisibilityForTextEffectID):
(WebKit::WebPageProxy::textIndicatorForTextEffectID):
(WebKit::WebPageProxy::decorationIndicatorForTextEffectID):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView addTextEffectForID:withData:]):
(-[WKContentView removeTextEffectForID:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::addTextEffectForID):
(WebKit::WebViewImpl::removeTextEffectForID):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::updateUnderlyingTextVisibilityForTextEffectID):
(WebKit::WebPage::createTextIndicatorForTextEffectID):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/309732@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
