Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 128fb92799f02173cf41a372e4e00c802cb99020
https://github.com/WebKit/WebKit/commit/128fb92799f02173cf41a372e4e00c802cb99020
Author: Zak Ridouh <[email protected]>
Date: 2026-03-19 (Thu, 19 Mar 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/mac/ColorInputTests.mm
Log Message:
-----------
[Site Isolation] Fix flaky ColorInputTests by waiting for color picker before
setting color
https://bugs.webkit.org/show_bug.cgi?id=310294
rdar://172931262
Reviewed by Aditya Keerthi.
The tests called _setSelectedColorForColorPicker: after a single
waitForNextPresentationUpdate,
which is sometimes not enough time to guarantee that the ShowColorPicker IPC
message has been
handled and internals().colorPicker is not null, due to recent site isolation
work in this area.
When we hit the null check in didChooseColor() is hit, the color change is
silently dropped,
causing us to read back the initial value #000000.
Spin the run loop until the WKPopoverColorWell appears in the view hierarchy
before calling
_setSelectedColorForColorPicker:, matching the approach used by
UIScriptControllerMac::isShowingColorPicker.
* Tools/TestWebKitAPI/Tests/mac/ColorInputTests.mm:
(TestWebKitAPI::isShowingColorPicker):
(TestWebKitAPI::TEST(ColorInputTests, SetColorUsingColorPicker)):
(TestWebKitAPI::TEST(ColorInputTests, SetColorWithAlphaUsingColorPicker)):
Canonical link: https://commits.webkit.org/309594@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
