Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db430c54ab4583f4aecdf395eb724dc5e3aa0ff9
https://github.com/WebKit/WebKit/commit/db430c54ab4583f4aecdf395eb724dc5e3aa0ff9
Author: Vitor Roriz <[email protected]>
Date: 2026-03-19 (Thu, 19 Mar 2026)
Changed paths:
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/css/CSSToLengthConversionData.h
M Source/WebCore/style/values/primitives/StyleLengthResolution.cpp
Log Message:
-----------
Remove CSSToLengthConversionData::computedLineHeightForFontUnits
https://bugs.webkit.org/show_bug.cgi?id=310290
rdar://172928233
Reviewed by Sammy Gill.
The only call site for computedLineHeightForFontUnits is in the lh unit
resolution else branch, which is only reached when !computingFontSize().
This means the computingFontSize() branch inside
computedLineHeightForFontUnits is dead code, and the method always
reduces to style()->computedLineHeight(). Therefore, we can call that
directly and remove computedLineHeightForFontUnits.
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::computedLineHeightForFontUnits const):
Deleted.
* Source/WebCore/css/CSSToLengthConversionData.h:
* Source/WebCore/style/values/primitives/StyleLengthResolution.cpp:
(WebCore::Style::computeNonCalcLengthDouble):
Canonical link: https://commits.webkit.org/309569@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
