Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 8e7bab03568e4fb509519afa490e12e7a573ba18
https://github.com/WebKit/WebKit/commit/8e7bab03568e4fb509519afa490e12e7a573ba18
Author: David Kilzer <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M Source/WebCore/testing/js/WebCoreTestSupport.cpp
Log Message:
-----------
Cherry-pick 309158@main (5aee90b4e66e).
https://bugs.webkit.org/show_bug.cgi?id=309781
WebCoreTestSupport::resetInternalsObject() crashes when Document::frame()
returns nullptr
<https://bugs.webkit.org/show_bug.cgi?id=309781>
<rdar://63019644>
Reviewed by Darin Adler.
Use the safe accessor `Document::page()` instead of calling
`document->frame()->page()` which dereferences a nullptr when the
document's frame has been disconnected.
Add a `RELEASE_ASSERT` to catch the case where `Document` is in an
unexpected state during post-test teardown rather than crashing with
an uninformative nullptr dereference.
No new tests since this would always crash when triggered.
* Source/WebCore/testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
Canonical link: https://commits.webkit.org/309158@main
Canonical link: https://commits.webkit.org/305877.187@webkitglib/2.52
Commit: 19b89382a67da9105e66913bc872fb22e76e40f6
https://github.com/WebKit/WebKit/commit/19b89382a67da9105e66913bc872fb22e76e40f6
Author: Aditya Keerthi <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
A LayoutTests/fast/lists/list-marker-margin-multiline-zoomed-expected.html
A LayoutTests/fast/lists/list-marker-margin-multiline-zoomed.html
M Source/WebCore/rendering/RenderListMarker.cpp
Log Message:
-----------
Cherry-pick 309152@main (4b403c87f553).
https://bugs.webkit.org/show_bug.cgi?id=309757
REGRESSION (301965@main): List items that span multiple lines have
incorrect margins when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=309757
rdar://172312498
Reviewed by Alan Baradlay.
Margin values computed in `RenderListMarker::updateInlineMargins` are based
on
font metrics which are already zoomed. Since `MarginEdge` stores unzoomed
values, and zoom is applied at resolution time via `resolveZoom`, margins
get
zoomed twice.
Fix by dividing out the zoom factor to avoid double-zooming.
* LayoutTests/fast/lists/list-marker-margin-multiline-zoomed-expected.html:
Added.
* LayoutTests/fast/lists/list-marker-margin-multiline-zoomed.html: Added.
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateInlineMargins):
Canonical link: https://commits.webkit.org/309152@main
Canonical link: https://commits.webkit.org/305877.188@webkitglib/2.52
Commit: 2a7345540f6dc6dffba190c8d54ff4305538dd03
https://github.com/WebKit/WebKit/commit/2a7345540f6dc6dffba190c8d54ff4305538dd03
Author: Charlie Wolfe <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M LayoutTests/compositing/layer-creation/sticky-overlap-extent-expected.txt
A
LayoutTests/fast/multicol/fixed-inside-columns-with-sticky-sibling-expected.html
A LayoutTests/fast/multicol/fixed-inside-columns-with-sticky-sibling.html
M
LayoutTests/platform/mac-sequoia-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt
M
LayoutTests/platform/mac-sonoma-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt
M
LayoutTests/platform/mac-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt
M Source/WebCore/rendering/RenderLayerCompositor.cpp
Log Message:
-----------
Cherry-pick 309147@main (f149f1d42c54).
https://bugs.webkit.org/show_bug.cgi?id=309729
REGRESSION(297346@main): Cookie dialog on hillsprofeeding.com is misplaced
https://bugs.webkit.org/show_bug.cgi?id=309729
rdar://171393860
Reviewed by Simon Fraser.
The sticky overlap extent added in 297346@main used computeStickyExtent
which covers the full
containing block range regardless of whether the page scrolls. This caused
false overlap, forcing
multicol content to composite. It also returned early, skipping the normal
overlapBounds()
computation.
Intersect the scroll-range inflation with the sticky extent so the result
is bounded by both how far
the page can scroll and how far the element can travel in the containing
block.
Test: fast/multicol/fixed-inside-columns-with-sticky-sibling.html
* LayoutTests/compositing/layer-creation/sticky-overlap-extent-expected.txt:
*
LayoutTests/fast/multicol/fixed-inside-columns-with-sticky-sibling-expected.html:
Added.
* LayoutTests/fast/multicol/fixed-inside-columns-with-sticky-sibling.html:
Added.
*
LayoutTests/platform/mac-sequoia-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt:
*
LayoutTests/platform/mac-sonoma-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt:
*
LayoutTests/platform/mac-wk2/compositing/layer-creation/sticky-overlap-extent-expected.txt:
Update these test expectations to account for the tighter extent.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeExtent const):
Canonical link: https://commits.webkit.org/309147@main
Canonical link: https://commits.webkit.org/305877.189@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/dcfb7872d449...2a7345540f6d
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
