Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9415fc43f62b99743e4fc0cbabcb28abbe939e74
https://github.com/WebKit/WebKit/commit/9415fc43f62b99743e4fc0cbabcb28abbe939e74
Author: Anne van Kesteren <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M Source/WebCore/layout/layouttree/LayoutElementBox.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/style/RenderStyle+GettersInlines.h
M Source/WebCore/style/values/flexbox/StyleFlexBasis.h
M Source/WebCore/style/values/sizing/StyleMaximumSize.h
M Source/WebCore/style/values/sizing/StyleMinimumSize.h
M Source/WebCore/style/values/sizing/StylePreferredSize.h
Log Message:
-----------
Style: split isStretch() from isIntrinsic()
https://bugs.webkit.org/show_bug.cgi?id=309686
Reviewed by Elika Etemad.
This is a purely mechanical change to ease review and blame for
subsequent changes.
-webkit-fill-available is not an intrinsic size and should not be
classified as such.
The following changes are made:
- isFillAvailable() is renamed to isStretch() as that is what it will
eventually become.
- isIntrinsic() has isStretch() removed.
- isIntrinsicOrStretch() takes over the old definition of isIntrinsic()
and for now that is what all callers are switched to, to keep this a
mechanical change.
- In RenderBox we remove two isIntrinsic() checks that are redundant
with !isKnownZero(). (We keep a leading isAuto() check that is also
redundant, but possibly cheaper.)
- We inline isLegacyIntrinsic() into its one caller in
RenderBlock::availableLogicalHeightForPercentageComputation() so we
can get rid of it.
This results in awkward code such as ElementBox::hasIntrinsicWidth()
containing an isIntrinsicOrStretch() check, but it seems better to be
explicit about such errors in the interim than try to address them as
part of this change.
Canonical link: https://commits.webkit.org/309146@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
