Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 37a89f9dc73d9e5ca301c08eb3c24a16010738cc
https://github.com/WebKit/WebKit/commit/37a89f9dc73d9e5ca301c08eb3c24a16010738cc
Author: Tadeu Zagallo <[email protected]>
Date: 2026-03-12 (Thu, 12 Mar 2026)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/diagnostic-expected.txt
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/size-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebGPU/WGSL/AST/ASTDiagnostic.h
M Source/WebGPU/WGSL/AST/ASTForStatement.h
M Source/WebGPU/WGSL/AST/ASTForward.h
M Source/WebGPU/WGSL/AST/ASTFunction.h
M Source/WebGPU/WGSL/AST/ASTLoopStatement.h
M Source/WebGPU/WGSL/AST/ASTStatement.h
M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
M Source/WebGPU/WGSL/AST/ASTStructure.h
M Source/WebGPU/WGSL/AST/ASTSwitchStatement.h
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTWhileStatement.h
M Source/WebGPU/WGSL/AttributeValidator.cpp
M Source/WebGPU/WGSL/EntryPointRewriter.cpp
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/UniformityAnalysis.cpp
M Source/WebGPU/WGSL/WGSL.cpp
M Source/WebGPU/WGSL/WGSLEnums.cpp
M Source/WebGPU/WGSL/WGSLEnums.h
M Source/WebGPU/WGSL/WGSLShaderModule.h
M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp
Log Message:
-----------
[WGSL] webgpu:shader,validation,parse,diagnostic:* is failing
https://bugs.webkit.org/show_bug.cgi?id=309652
rdar://150364837
Reviewed by Mike Wyrzykowski.
Validate diagnostic attributes and directives in all nodes and follow
them in uniformity analysis.
*
LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/diagnostic-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebGPU/WGSL/AST/ASTDiagnostic.h:
(WGSL::AST::DiagnosticContainer::severityFor const):
(WGSL::AST::DiagnosticContainer::setSeverityFor):
* Source/WebGPU/WGSL/AST/ASTForStatement.h:
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTFunction.h:
* Source/WebGPU/WGSL/AST/ASTLoopStatement.h:
(WGSL::AST::Continuing::Continuing):
* Source/WebGPU/WGSL/AST/ASTStatement.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStructure.h:
* Source/WebGPU/WGSL/AST/ASTSwitchStatement.h:
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTWhileStatement.h:
* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
(WGSL::AttributeValidator::parseDiagnostic):
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::checkReturnType):
(WGSL::EntryPointRewriter::constructInputStruct):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::packStructType):
(WGSL::RewriteGlobalVariables::finalizeArgumentBufferStruct):
(WGSL::RewriteGlobalVariables::storeInitialValue):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::parse):
(WGSL::Parser<Lexer>::parseShader):
(WGSL::Parser<Lexer>::parseDeclaration):
(WGSL::Parser<Lexer>::parseAttributes):
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseDiagnostic):
(WGSL::Parser<Lexer>::parseStructure):
(WGSL::Parser<Lexer>::parseStatement):
(WGSL::Parser<Lexer>::parseCompoundStatement):
(WGSL::Parser<Lexer>::parseForStatement):
(WGSL::Parser<Lexer>::parseLoopStatement):
(WGSL::Parser<Lexer>::parseSwitchStatement):
(WGSL::Parser<Lexer>::parseWhileStatement):
* Source/WebGPU/WGSL/ParserPrivate.h:
(WGSL::Parser::takeWarnings):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/UniformityAnalysis.cpp:
(WGSL::uniformityAnalysis):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::staticCheck):
(WGSL::prepareImpl):
* Source/WebGPU/WGSL/WGSLEnums.cpp:
* Source/WebGPU/WGSL/WGSLEnums.h:
* Source/WebGPU/WGSL/WGSLShaderModule.h:
* Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp:
Canonical link: https://commits.webkit.org/309139@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
