Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 219958859919aca05ee6b9e4dd8a67f773187225
https://github.com/WebKit/WebKit/commit/219958859919aca05ee6b9e4dd8a67f773187225
Author: Tyler Wilcock <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
A
LayoutTests/accessibility/popover-remove-controller-then-popover-crash-expected.txt
A
LayoutTests/accessibility/popover-remove-controller-then-popover-crash.html
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
Log Message:
-----------
AX: AXObjectCache::onPopoverToggled can resolve relations downstream of
element removal, which causes a release assert
https://bugs.webkit.org/show_bug.cgi?id=309716
rdar://172255285
Reviewed by Joshua Hoffman.
Calling controllers() from onPopoverToggle during element removal
can trigger updateRelationsForTree, which resolves ID-based attributes via
getElementById while the tree scope's ordered map is in an inconsistent
state, causing a crash. Defer the work to performDeferredCacheUpdate
when the DOM is stable.
*
LayoutTests/accessibility/popover-remove-controller-then-popover-crash-expected.txt:
Added.
* LayoutTests/accessibility/popover-remove-controller-then-popover-crash.html:
Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::onPopoverToggle):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::handleDeferredPopoverToggle):
* Source/WebCore/accessibility/AXObjectCache.h:
Canonical link: https://commits.webkit.org/309115@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
