Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a798a7d546e6bd5e2ba721d3ddf8fa64af9369cb
https://github.com/WebKit/WebKit/commit/a798a7d546e6bd5e2ba721d3ddf8fa64af9369cb
Author: Etienne Segonzac <[email protected]>
Date: 2026-03-11 (Wed, 11 Mar 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h
M Source/WebKit/GPUProcess/graphics/Model/USDModel.swift
M Source/WebKit/WebProcess/Model/WebModelPlayer.h
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Setting model.currentTime doesn't work with the WebModelPlayer
https://bugs.webkit.org/show_bug.cgi?id=309677
<rdar://172279090>
Reviewed by Mike Wyrzykowski.
Add the missing plumbing so that setting the `currentTime` attribute
on a model properly updates the `USDModel`.
* Source/WebKit/GPUProcess/graphics/Model/ModelTypes.h:
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(USDModelLoader.loadModel(from:)):
(USDModelLoader.loadModel(_:)):
(USDModelLoader.setupTimes(from:)):
(USDModelLoader.duration):
(USDModelLoader.setCurrentTime(_:)):
(USDModelLoader.update(_:)):
(WKBridgeModelLoader.setCurrentTime(_:)):
Clarify animation timing management:
- startTime, endTime, deltaTime all use wall clock values
- the timeCodePerSecond is only applied at the usdLoader boundary
* Source/WebKit/WebProcess/Model/WebModelPlayer.h:
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::currentTime const):
(WebKit::WebModelPlayer::setCurrentTime):
Like in ModelProcessModelPlayer, clamp the currentTime value before
sending it forward.
Canonical link: https://commits.webkit.org/309098@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
