Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 51a2b043397898b8cc65442b1e4150ef09f0cf3f
https://github.com/WebKit/WebKit/commit/51a2b043397898b8cc65442b1e4150ef09f0cf3f
Author: Aakash Jain <[email protected]>
Date: 2026-03-10 (Tue, 10 Mar 2026)
Changed paths:
M Tools/CISupport/ews-build/twisted_additions.py
Log Message:
-----------
[ews] various steps with network requests sometimes get stuck indefinitely
https://bugs.webkit.org/show_bug.cgi?id=305779
rdar://problem/168609841
Reviewed by Brianna Fan.
The previous fix in 305961@main added a timeout on response body delivery to
prevent indefinite hangs.
However, it didn't cover all the possible scenarios.
There are three distinct phases where a network request can hang indefinitely:
1. TCP connection establishment - already covered by connectTimeout in twisted
Agent
2. Waiting for HTTP response headers after connection
3. Response body delivery - covered by the previous fix in 305961@main
Scenario 2 was not covered, if a server (e.g.: GitHub) accepts the TCP
connection but never sends
HTTP response headers, agent.request() blocks indefinitely and the body
delivery timeout is never reached.
This change adds timeout to cover second scenario as well.
* Tools/CISupport/ews-build/twisted_additions.py:
(TwistedAdditions.request):
Canonical link: https://commits.webkit.org/309004@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
