Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 093666c8c39ccf291e5054bb134d41e1173613aa
https://github.com/WebKit/WebKit/commit/093666c8c39ccf291e5054bb134d41e1173613aa
Author: Aditya Keerthi <[email protected]>
Date: 2026-03-04 (Wed, 04 Mar 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[Writing Tools] 'Compose' option is disabled for non-editable text
https://bugs.webkit.org/show_bug.cgi?id=309166
rdar://162515780
Reviewed by Richard Robinson and Abrar Rahman Protyasha.
289243@main made it so that 'Compose' should only be enabled in editable
content. However, soon after that change, AppKit made a change to always
enable 'Compose'.
The desired behavior is that 'Compose' is always enabled. Regardless of
whether there is a selection.
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::shouldEnableWritingToolsRequestedTool const):
Update logic to match the system behavior. If there is no selection,
'Compose' operates in the Writing Tools panel, using the entire text
content of the page as context.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
Update tests to reflect that 'Compose' should be enabled for non-editable
text.
(TEST(WritingTools, ContextMenuItemsNonEditable)):
(TEST(WritingTools, AppMenuNonEditable)):
Canonical link: https://commits.webkit.org/308672@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
