Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58cfbf6a335ad7652c61d3da64c15b089651c62d
https://github.com/WebKit/WebKit/commit/58cfbf6a335ad7652c61d3da64c15b089651c62d
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-02-27 (Fri, 27 Feb 2026)
Changed paths:
M Source/WebKit/CMakeLists.txt
Log Message:
-----------
[CMake] Add missing dependencies to GENERATE_IDL_BINDINGS macro
https://bugs.webkit.org/show_bug.cgi?id=308790
Reviewed by Adrian Perez de Castro.
The GENERATE_IDL_BINDINGS macro in Source/WebKit/CMakeLists.txt was only
listing the IDL files themselves in its DEPENDS list, but not the binding
scripts used to generate the output. This meant that changes to those
scripts did not invalidate the generated JSWebExtensionAPI*.h files,
causing stale headers to be used in subsequent builds.
This was exposed by commit 308310@main which modified the script
CodeGeneratorExtensions.pm, causing build failures on some WPE bots.
The Apple/Xcode build was not affected because Source/WebKit/DerivedSources.make
already correctly tracks all these scripts as dependencies on the JS%.h rule
via BINDINGS_SCRIPTS and IDL_ATTRIBUTES_FILE.
This patch brings the CMake build to parity with DerivedSources.make by
adding the equivalent dependencies to GENERATE_IDL_BINDINGS.
* Source/WebKit/CMakeLists.txt:
Canonical link: https://commits.webkit.org/308329@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
