Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a21376ccff417f7a84ab2bb894fe22bba7c06b3
https://github.com/WebKit/WebKit/commit/5a21376ccff417f7a84ab2bb894fe22bba7c06b3
Author: Sam Weinig <[email protected]>
Date: 2026-02-26 (Thu, 26 Feb 2026)
Changed paths:
A
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-function-crash-expected.txt
A
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-function-crash.html
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.h
M Source/WebCore/style/values/shapes/StyleShapeOutside.cpp
Log Message:
-----------
Crash when using `shape-outside: shape(...)`
https://bugs.webkit.org/show_bug.cgi?id=308649
Reviewed by Simon Fraser.
Extends the list of rejected <basic-shape> functions for `shape-outside` to also
include `shape()`.
Also adds style building time check so that any non-parser code paths that
might try
to construct a `shape-outside` property value don't succeed.
Test: fast/shapes/shape-outside-floats/shape-outside-shape-function-crash.html
*
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-function-crash-expected.txt:
Added.
*
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-function-crash.html:
Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Motion.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Shapes.h:
* Source/WebCore/style/values/shapes/StyleShapeOutside.cpp:
Canonical link: https://commits.webkit.org/308286@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
