Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b7f2638a60d196a14ce32fa6bc2e443822370f7
https://github.com/WebKit/WebKit/commit/7b7f2638a60d196a14ce32fa6bc2e443822370f7
Author: Anne van Kesteren <[email protected]>
Date: 2026-02-20 (Fri, 20 Feb 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/button-in-popover-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-events-2.optional-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-iterate-before-beginning.optional-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-keyboard-behavior.optional-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-picker-hover-active-pseudo-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-picker-interactive-element-focus.optional-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-pseudo-open-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/button-in-popover-expected.txt
M Source/WebCore/html/HTMLSelectElement.cpp
Log Message:
-----------
Enhanced <select>: toggle picker on mousedown
https://bugs.webkit.org/show_bug.cgi?id=308296
rdar://170742798
Reviewed by Tim Nguyen.
appearance: base-select ::picker(select) appears below a <select> by
default and as such clicking the <select> is expected to close it. This
also happens for normal <select>s on macOS as a side effect of how the
OS picker works.
To distinguish a click on the <select>'s "button" from a click anywhere
on ::picker(select) some composed tree traversal is necessary
unfortunately.
We also add some early returns for the different event types for
clarity.
What appears as a regression in select-events-2.optional.html is
actually a progression as before we did not get into a state where it
could fail. Both of the failures in that test are due to
preventDefault() being called in a microtask which at least in
combination with WebKit's test runner does not happen at the right
point in time.
select-popover-exit-animation.html likewise did not get into a state
where it could fail before.
Canonical link: https://commits.webkit.org/307925@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
