- Revision
- 113719
- Author
- commit-qu...@webkit.org
- Date
- 2012-04-10 08:35:37 -0700 (Tue, 10 Apr 2012)
Log Message
[EFL] LayoutTestController needs implementation of addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82446
Source/WebKit/efl:
Add missing implementation addUserStyleSheet to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserStyleSheet):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
so that we can unskip related tests from the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserStyleSheet): Implemented.
LayoutTests:
Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html
userscripts/script-run-at-end.html
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113718 => 113719)
--- trunk/LayoutTests/ChangeLog 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/LayoutTests/ChangeLog 2012-04-10 15:35:37 UTC (rev 113719)
@@ -1,3 +1,18 @@
+2012-04-10 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] LayoutTestController needs implementation of addUserStyleSheet
+ https://bugs.webkit.org/show_bug.cgi?id=82446
+
+ Unskipping the following test cases:
+ userscripts/mixed-case-stylesheet.html
+ userscripts/user-style-all-frames.html
+ userscripts/simple-stylesheet.html
+ userscripts/script-run-at-end.html
+
+ Reviewed by Antonio Gomes.
+
+ * platform/efl/Skipped:
+
2012-04-10 Csaba Osztrogonác <o...@webkit.org>
[Qt][WK2] Unreviewed gardening, skip a test to try to paint the bot greener.
Modified: trunk/LayoutTests/platform/efl/Skipped (113718 => 113719)
--- trunk/LayoutTests/platform/efl/Skipped 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-04-10 15:35:37 UTC (rev 113719)
@@ -632,12 +632,19 @@
media/restore-from-page-cache.html
# EFL's LayoutTestController does not implement addUserScript
-userscripts
+userscripts/document-element-available-at-start.html
+userscripts/script-not-run-for-fragments.html
+userscripts/script-run-at-start.html
+userscripts/user-script-all-frames.html
+userscripts/user-script-audio-document.html
+userscripts/user-script-image-document.html
+userscripts/user-script-plugin-document.html
+userscripts/user-script-top-frame-only.html
+userscripts/user-script-video-document.html
+userscripts/user-style-top-frame-only.html
+userscripts/window-onerror-for-isolated-world-1.html
+userscripts/window-onerror-for-isolated-world-2.html
-# EFL's LayoutTestController does not implement addUserStyleSheet
-#userscripts
-printing/page-rule-selection.html
-
# EFL's LayoutTestController does not implement setAsynchronousSpellCheckingEnabled
editing/spelling/spellcheck-paste.html
editing/spelling/spellcheck-paste-disabled.html
Modified: trunk/Source/WebKit/efl/ChangeLog (113718 => 113719)
--- trunk/Source/WebKit/efl/ChangeLog 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-04-10 15:35:37 UTC (rev 113719)
@@ -1,3 +1,17 @@
+2012-04-10 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] LayoutTestController needs implementation of addUserStyleSheet
+ https://bugs.webkit.org/show_bug.cgi?id=82446
+
+ Add missing implementation addUserStyleSheet to EFL's
+ DumpRenderTreeSupport.
+
+ Reviewed by Antonio Gomes.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::addUserStyleSheet):
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
2012-04-04 Raphael Kubo da Costa <rak...@webkit.org>
Another unreviewed attempt at getting the EFL build bot to a
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (113718 => 113719)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-04-10 15:35:37 UTC (rev 113719)
@@ -37,6 +37,7 @@
#include <IntRect.h>
#include <JSCSSStyleDeclaration.h>
#include <JSElement.h>
+#include <PageGroup.h>
#include <PrintContext.h>
#include <RenderTreeAsText.h>
#include <Settings.h>
@@ -350,6 +351,15 @@
page->setDefersLoading(defers);
}
+void DumpRenderTreeSupportEfl::addUserStyleSheet(const Evas_Object* ewkView, const char* sourceCode, bool allFrames)
+{
+ WebCore::Page* page = EWKPrivate::corePage(ewkView);
+ if (!page)
+ return;
+
+ page->group().addUserStyleSheetToWorld(WebCore::mainThreadNormalWorld(), sourceCode, WebCore::KURL(), nullptr, nullptr, allFrames ? WebCore::InjectInAllFrames : WebCore::InjectInTopFrameOnly);
+}
+
bool DumpRenderTreeSupportEfl::findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions options)
{
WebCore::Page* page = EWKPrivate::corePage(ewkView);
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (113718 => 113719)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2012-04-10 15:35:37 UTC (rev 113719)
@@ -68,6 +68,7 @@
static void setAutofilled(JSContextRef, JSValueRef nodeObject, bool autofilled);
static void setDefersLoading(Evas_Object* ewkView, bool defers);
+ static void addUserStyleSheet(const Evas_Object* ewkView, const char* sourceCode, bool allFrames);
static bool findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions);
static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
Modified: trunk/Tools/ChangeLog (113718 => 113719)
--- trunk/Tools/ChangeLog 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/Tools/ChangeLog 2012-04-10 15:35:37 UTC (rev 113719)
@@ -1,3 +1,16 @@
+2012-04-10 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] LayoutTestController needs implementation of addUserStyleSheet
+ https://bugs.webkit.org/show_bug.cgi?id=82446
+
+ Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
+ so that we can unskip related tests from the skip list.
+
+ Reviewed by Antonio Gomes.
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::addUserStyleSheet): Implemented.
+
2012-04-10 Philip Rogers <p...@google.com>
Adding myself to committers.py!
Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (113718 => 113719)
--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-10 15:33:33 UTC (rev 113718)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp 2012-04-10 15:35:37 UTC (rev 113719)
@@ -655,10 +655,9 @@
notImplemented();
}
-void LayoutTestController::addUserStyleSheet(JSStringRef, bool)
+void LayoutTestController::addUserStyleSheet(JSStringRef source, bool allFrames)
{
- // FIXME: needs more investigation why userscripts/user-style-top-frame-only.html fails when allFrames is false.
- notImplemented();
+ DumpRenderTreeSupportEfl::addUserStyleSheet(browser->mainView(), source->ustring().utf8().data(), allFrames);
}
void LayoutTestController::setDeveloperExtrasEnabled(bool enabled)
