Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1c4609d258142b146f33187cc9fe42fb074534df
https://github.com/WebKit/WebKit/commit/1c4609d258142b146f33187cc9fe42fb074534df
Author: Antoine Quint <[email protected]>
Date: 2025-11-10 (Mon, 10 Nov 2025)
Changed paths:
M Source/WebCore/animation/AnimationEffect.cpp
M Source/WebCore/animation/AnimationEffect.h
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
Log Message:
-----------
[web-animations] make `KeyframeEffect::setAnimatedPropertiesInStyle()` const
https://bugs.webkit.org/show_bug.cgi?id=302246
Reviewed by Anne van Kesteren.
This method should only apply its current state to a given style, it's up to its
caller to make sure the effect state is current. There were two reasons this
method
couldn't be const as-is:
1. a call to `updateBlendingKeyframes()`, which we remove since it's already
made in
`KeyframeEffect::apply()`, which calls into `setAnimatedPropertiesInStyle()`
2. a call to `iterationDuration()`, which we keep but add a `const` flavor with
an
assertion that it doesn't require recomputation
* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::iterationDuration):
(WebCore::AnimationEffect::iterationDuration const):
* Source/WebCore/animation/AnimationEffect.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle const):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:
Canonical link: https://commits.webkit.org/302792@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
