Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: daa49cf14304b10bef2970a945e8dc4d8477970b
https://github.com/WebKit/WebKit/commit/daa49cf14304b10bef2970a945e8dc4d8477970b
Author: Antoine Quint <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimation.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimation.h
Log Message:
-----------
[threaded-animations] remove extraneous ref-churn in
`RemoteAnimation::apply()`
https://bugs.webkit.org/show_bug.cgi?id=302015
rdar://164097428
Reviewed by Alan Baradlay, Brent Fulgham, and Vitor Roriz.
Adopt the advice to "mark data members that are smart pointers as const if
they never get reassigned" [0] for both `Ref` members of `RemoteAnimation`.
This allows us to remove the extra `Ref` in the `apply()` method.
[0]
https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#mark-data-members-that-are-smart-pointers-as-const-if-they-never-get-reassigned
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimation.cpp:
(WebKit::RemoteAnimation::apply):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAnimation.h:
Canonical link: https://commits.webkit.org/302623@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications