Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07e07d5fd650bcdd7fb526500ed5253010cef6c5
https://github.com/WebKit/WebKit/commit/07e07d5fd650bcdd7fb526500ed5253010cef6c5
Author: Devin Rousso <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
M Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp
M Source/JavaScriptCore/inspector/InspectorAgentRegistry.h
M Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
M Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h
M
Source/JavaScriptCore/inspector/augmentable/AugmentableInspectorController.h
M
Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py
M
Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-debuggableTypes.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-exposed-as-other-name.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetTypes.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result
M Source/WebCore/inspector/InspectorController.cpp
M Source/WebCore/inspector/WorkerInspectorController.cpp
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
Log Message:
-----------
Web Inspector: use `UniqueRef` for `AgentRegistry`
https://bugs.webkit.org/show_bug.cgi?id=301633
Reviewed by BJ Burg.
* Source/JavaScriptCore/inspector/InspectorAgentRegistry.h:
* Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp:
(Inspector::AgentRegistry::append):
It assumes that all agents exist so using `std::unique_ptr` is not ideal as
that can be `nullptr`.
As such, `UniqueRef` is better since it cannot be `nullptr`.
* Source/WebCore/inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::createLazyAgents):
(WebCore::InspectorController::ensureInspectorAgent):
(WebCore::InspectorController::ensureDOMAgent):
(WebCore::InspectorController::ensurePageAgent):
* Source/WebCore/inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::createLazyAgents):
(WebCore::WorkerInspectorController::ensureDebuggerAgent):
* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp:
(WebKit::WebPageInspectorController::WebPageInspectorController):
(WebKit::WebPageInspectorController::createLazyAgents):
* Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h:
* Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::registerAlternateAgent):
(Inspector::JSGlobalObjectInspectorController::ensureInspectorAgent):
(Inspector::JSGlobalObjectInspectorController::ensureDebuggerAgent):
(Inspector::JSGlobalObjectInspectorController::createLazyAgents):
* Source/JavaScriptCore/inspector/augmentable/AugmentableInspectorController.h:
* Source/JavaScriptCore/inspector/scripts/codegen/objc_generator_templates.py:
Create all agents using `makeUniqueRef` instead.
Also remove unnecessary `.get()` since `UniqueRef` can be converted to a
reference.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-exposed-as-other-name.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-targetTypes.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
*
Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
Canonical link: https://commits.webkit.org/302594@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
