Branch: refs/heads/webkitglib/2.50
Home: https://github.com/WebKit/WebKit
Commit: ac50fce652c2c2ba76c38dfbe37d8e18fc4f38f1
https://github.com/WebKit/WebKit/commit/ac50fce652c2c2ba76c38dfbe37d8e18fc4f38f1
Author: Brandon Stewart <[email protected]>
Date: 2025-11-04 (Tue, 04 Nov 2025)
Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.cpp
Log Message:
-----------
Cherry-pick 302541@main (92dc5fc313bd).
https://bugs.webkit.org/show_bug.cgi?id=301924
[masonry] Crash with 0 elements
https://bugs.webkit.org/show_bug.cgi?id=301924
rdar://problem/164003234
Reviewed by Elika Etemad.
When a masonry container has 0 elements it is causing a crash, because we
are asserting during item placement that we have tracks. This isn't accurate,
because we have no elements.
Since the test cases swapped over to using display: masonry this is the
test case I used to verify the fix.
<!DOCTYPE html>
<html>
<style>
.empty-container {
display: grid;
grid-template-rows: masonry; and grid-template-columns: masonry;
}
</style>
<body>
<p>Test that an empty masonry container renders nothing.</p>
<div class="empty-container"></div>
</body>
</html>
* Source/WebCore/rendering/GridMasonryLayout.cpp
Canonical link: https://commits.webkit.org/302541@main
Canonical link: https://commits.webkit.org/298234.222@webkitglib/2.50
Commit: b5e35ff7236bcb6d1786152c0e79ea831eae40f4
https://github.com/WebKit/WebKit/commit/b5e35ff7236bcb6d1786152c0e79ea831eae40f4
Author: Chris Dumez <[email protected]>
Date: 2025-11-05 (Wed, 05 Nov 2025)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSNavigateEventCustom.cpp
A Source/WebCore/bindings/js/JSNavigationCustom.cpp
M Source/WebCore/dom/Microtasks.h
M Source/WebCore/page/NavigateEvent.cpp
M Source/WebCore/page/NavigateEvent.h
M Source/WebCore/page/NavigateEvent.idl
M Source/WebCore/page/Navigation.h
M Source/WebCore/page/Navigation.idl
Log Message:
-----------
Cherry-pick 302530@main (86a2114b3e46).
https://bugs.webkit.org/show_bug.cgi?id=301894
imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-204-205-download-then-same-document.html
is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=301894
Reviewed by Ryosuke Niwa.
The crash was due to the Navigation object not marking its associated
ongoing NavigateEvent when getting visited. Similarly, the NavigateEvent
would fail to mark its associated AbortSignal when visited. As a result,
the AbortSignal's JS wrapper could get garbage collected and we would
crash trying to dispatch the abort event on it.
The test was flakily crashing in debug before this change and is now
reliably passing.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSNavigateEventCustom.cpp:
(WebCore::JSNavigateEvent::visitAdditionalChildren):
* Source/WebCore/bindings/js/JSNavigationCustom.cpp: Copied from
Source/WebCore/bindings/js/JSNavigateEventCustom.cpp.
(WebCore::JSNavigation::visitAdditionalChildren):
* Source/WebCore/dom/Microtasks.h:
* Source/WebCore/page/NavigateEvent.cpp:
(WebCore::root):
* Source/WebCore/page/NavigateEvent.h:
* Source/WebCore/page/NavigateEvent.idl:
* Source/WebCore/page/Navigation.h:
* Source/WebCore/page/Navigation.idl:
Canonical link: https://commits.webkit.org/302530@main
Canonical link: https://commits.webkit.org/298234.223@webkitglib/2.50
Compare: https://github.com/WebKit/WebKit/compare/fe974cd748e5...b5e35ff7236b
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
