Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3776e594632cd343a09a1ebe8bc6456aa3438a6c
https://github.com/WebKit/WebKit/commit/3776e594632cd343a09a1ebe8bc6456aa3438a6c
Author: Chris Dumez <[email protected]>
Date: 2025-10-30 (Thu, 30 Oct 2025)
Changed paths:
A LayoutTests/fast/svg/SVGAnimationElement-targetElement-expected.txt
A LayoutTests/fast/svg/SVGAnimationElement-targetElement.html
R LayoutTests/fast/svg/SVGPathElement-toJS-crash-expected.txt
R LayoutTests/fast/svg/SVGPathElement-toJS-crash.html
A LayoutTests/fast/svg/SVGViewSpec-viewTarget-expected.txt
A LayoutTests/fast/svg/SVGViewSpec-viewTarget.svg
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Log Message:
-----------
[Bindings] Fix crashes in `verifyVTable<>()` for some SVG types after
301038@main
https://bugs.webkit.org/show_bug.cgi?id=301679
rdar://162589534
Reviewed by Darin Adler.
We had a list of exceptions in `GetGnuVTableOffsetForType()` in the bindings
generator where we used a different offset for the vtable than the default
one. This included SVG types and ApplePaySession.
After adding test coverage for `toJSNewlyCreated()` for these types (which
ends up calling `verifyVTable<>()`), it turns out that the offset is wrong
for all SVG types and the check would fail. The SVG types do not need to
use a different offset after all nowadays.
The ApplePaySession type does need the special offset and it is validated by
existing layout tests (e.g.
http/tests/ssl/applepay/ApplePayCancelEvent.https.html)
The tests were written by Claude AI.
Tests: fast/svg/SVGAnimationElement-targetElement.html
fast/svg/SVGViewSpec-viewTarget.svg
* LayoutTests/fast/svg/SVGAnimationElement-targetElement-expected.txt: Added.
* LayoutTests/fast/svg/SVGAnimationElement-targetElement.html: Added.
* LayoutTests/fast/svg/SVGPathElement-toJS-crash-expected.txt: Removed.
* LayoutTests/fast/svg/SVGPathElement-toJS-crash.html: Removed.
* LayoutTests/fast/svg/SVGViewSpec-viewTarget-expected.txt: Added.
* LayoutTests/fast/svg/SVGViewSpec-viewTarget.svg: Added.
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
Canonical link: https://commits.webkit.org/302339@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
