Title: [113543] trunk/Source/WebCore
- Revision
- 113543
- Author
- [email protected]
- Date
- 2012-04-07 01:09:47 -0700 (Sat, 07 Apr 2012)
Log Message
2012-04-07 Nikolas Zimmermann <[email protected]>
FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416
Inofficially rubber-stamped by Tim Horton.
Lots of svg/as-image/ crash on debug builds. FrameData is used in a Vector and currently
special VectorTraits force it to be initialized with memset(), nulling all members, instead
of properly initializing them causing the ImageOrientation bug. To be able to remove the
SimpleClassVectorTraits specialization, we have to allow FrameData to be copied.
* platform/graphics/BitmapImage.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113542 => 113543)
--- trunk/Source/WebCore/ChangeLog 2012-04-07 07:38:48 UTC (rev 113542)
+++ trunk/Source/WebCore/ChangeLog 2012-04-07 08:09:47 UTC (rev 113543)
@@ -1,5 +1,19 @@
2012-04-07 Nikolas Zimmermann <[email protected]>
+ FrameData constructor zeroes all fields, causing ImageOrientation to be 0
+ https://bugs.webkit.org/show_bug.cgi?id=83416
+
+ Inofficially rubber-stamped by Tim Horton.
+
+ Lots of svg/as-image/ crash on debug builds. FrameData is used in a Vector and currently
+ special VectorTraits force it to be initialized with memset(), nulling all members, instead
+ of properly initializing them causing the ImageOrientation bug. To be able to remove the
+ SimpleClassVectorTraits specialization, we have to allow FrameData to be copied.
+
+ * platform/graphics/BitmapImage.h:
+
+2012-04-07 Nikolas Zimmermann <[email protected]>
+
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.h (113542 => 113543)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-04-07 07:38:48 UTC (rev 113542)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.h 2012-04-07 08:09:47 UTC (rev 113543)
@@ -50,13 +50,6 @@
struct FrameData;
}
-namespace WTF {
- // FIXME: This declaration gives FrameData a default constructor that zeroes
- // all its data members, even though FrameData's default constructor defined
- // below does not zero all its data members. One of these must be wrong!
- template<> struct VectorTraits<WebCore::FrameData> : public SimpleClassVectorTraits { };
-}
-
namespace WebCore {
template <typename T> class Timer;
@@ -66,7 +59,6 @@
// ================================================
struct FrameData {
- WTF_MAKE_NONCOPYABLE(FrameData);
public:
FrameData()
: m_frame(0)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
