Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92b7489e014afb385a4b51788d4c2adcc678966f
https://github.com/WebKit/WebKit/commit/92b7489e014afb385a4b51788d4c2adcc678966f
Author: Zak Ridouh <[email protected]>
Date: 2025-10-21 (Tue, 21 Oct 2025)
Changed paths:
M Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py
Log Message:
-----------
[MiniBrowser] Fix logging channel names being normalized as URLs
https://bugs.webkit.org/show_bug.cgi?id=301227
rdar://163146056
Reviewed by Abrar Rahman Protyasha and Basuke Suzuki.
After commits.webkit.org/301651@main, we treat strings without a scheme as a
URL, and
normalize it with the proper scheme before passing it to MIniBrowser.
This caused issues with WebKit logging channels, which do not have schemes, and
thus
were being treated as URLs and getting schemes added.
Fix this by only normalizing if it actually looks like a URL (to not
accidentally normalize a logging stream):
- starts with localhost
- looks like an IP address
- contains a dot (likely a domain) or slash (path)
* Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py:
(main):
Canonical link: https://commits.webkit.org/301927@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications