Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4802933f09a636a7b71317873569ec931dbba72
https://github.com/WebKit/WebKit/commit/c4802933f09a636a7b71317873569ec931dbba72
Author: Sihui Liu <[email protected]>
Date: 2025-10-28 (Tue, 28 Oct 2025)
Changed paths:
R LayoutTests/http/tests/IndexedDB/storage-limit-1.https-expected.txt
R LayoutTests/http/tests/IndexedDB/storage-limit-1.https.html
R LayoutTests/http/tests/IndexedDB/storage-limit-2.https-expected.txt
R LayoutTests/http/tests/IndexedDB/storage-limit-2.https.html
R LayoutTests/http/tests/IndexedDB/storage-limit.https-expected.txt
R LayoutTests/http/tests/IndexedDB/storage-limit.https.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm
Log Message:
-----------
[ iOS ] http/tests/IndexedDB/storage-limit-1.https.html is a flakey text
failure
https://bugs.webkit.org/show_bug.cgi?id=295993
rdar://155891191
Reviewed by Youenn Fablet.
Replace http/tests/IndexedDB/storage-limit* tests with API test. The
storage-limit layout tests have strict requirements
for storage usage (e.g. checking operation succeeds when storing data with size
a bit smaller than quota, and fails when
storing data with size a bit bigger than quota). If multiple WKTR instances are
running storage tests in parallel (which
is what bot does), the tests will write to the same storage location, the
results can be flaky (as the usage is not just
controlled by one test). To fix this, we now add new API test to cover the
storage-limit cases. The API test uses custom
data store (instead of the default one), so it is less likely to conflict with
other tests even run in parallel. Also it
is more straightforward to set fixed quota on data store in API test (by
default WebKit sets quota based on available
disk space, but for these tests we need fixed quota to have deterministic
behavior), compared to using window.testRunner
APIs in layout test (where we need to disable origin quota ratio and quota
increase flags).
storage-limit.https.html verifies IndexedDB throws error on exceeding quota. It
is covered by
WKWebsiteDataStoreConfiguration.OriginQuotaRatio.
storage-limit-1.https.html and storage-limit-2.https.html verify IndexedDB and
CacheStorage share the same origin quota,
and the usage for quota computation will be initialized with storage on disk.
They are covered by
StorageQuota.OriginQuotaSharedByCacheStorageAndIndexedDB.
* LayoutTests/http/tests/IndexedDB/storage-limit-1.https-expected.txt: Removed.
* LayoutTests/http/tests/IndexedDB/storage-limit-1.https.html: Removed.
* LayoutTests/http/tests/IndexedDB/storage-limit-2.https-expected.txt: Removed.
* LayoutTests/http/tests/IndexedDB/storage-limit-2.https.html: Removed.
* LayoutTests/http/tests/IndexedDB/storage-limit.https-expected.txt: Removed.
* LayoutTests/http/tests/IndexedDB/storage-limit.https.html: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
((StorageQuota, OriginQuotaSharedByCacheStorageAndIndexedDB)):
Canonical link: https://commits.webkit.org/302244@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
