Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b4ed0533cea60126d97815660295db151ae86f0
https://github.com/WebKit/WebKit/commit/5b4ed0533cea60126d97815660295db151ae86f0
Author: Dana Estra <[email protected]>
Date: 2025-10-24 (Fri, 24 Oct 2025)
Changed paths:
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/mac/SkipAdInPictureInPicture.html
A Tools/TestWebKitAPI/Tests/mac/SkipAdInPictureInPicture.mm
Log Message:
-----------
Add API tests for skipping ads in PIP
https://bugs.webkit.org/show_bug.cgi?id=289744
rdar://146994962
Reviewed by Jer Noble.
This patch adds two API tests for ad skipping in PIP. The first
test checks that we set the PIP playbackstate's PrerollAttributes
property to a nonnull value when the webpage has set the media session
skipad action handler and a video is in pip.
The second test checks the prerollAttributes stays null when a video
goes into pip and the webpage has not set the skipAd action handler.
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/mac/SkipAdInPictureInPicture.html: Added.
* Tools/TestWebKitAPI/Tests/mac/SkipAdInPictureInPicture.mm: Added.
(-[SkipAdInPiPFullscreenDelegate
_webView:hasVideoInPictureInPictureDidChange:]):
(TestWebKitAPI::createWebView):
(TestWebKitAPI::TEST(SkipAdInPictureInPicture, VideoHasAd)):
(TestWebKitAPI::TEST(SkipAdInPictureInPicture, VideoHasNoAd)):
Canonical link: https://commits.webkit.org/302095@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
